Repository navigation
Conversation
Preserve exact SDK selection and align CI and documentation references. Verified the scanner manifest-list digest against official MCR metadata. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
@codex review |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned Files
|
There was a problem hiding this comment.
🔵 Needs a closer look
The supplied evidence lacks successful full CI and network-disabled Docker scanner acceptance results, leaving SDK feature-band image/runtime compatibility unresolved by static review alone.
No open issues 🎉
What changed in this PR
Aligns DLLPickle’s build toolchain and offline scanner on .NET SDK 10.0.404, addressing the exact-version mismatch described in #333 and superseding the image-only update in #331. Runtime support and NuGet packages remain unchanged.
Changes:
- Updates the SDK pin and scanner image tag/digest together, retaining disabled roll-forward and prerelease selection.
- Aligns all four hard-coded CI SDK selections.
- Updates the configuration reference and changelog.
| File | Description |
|---|---|
global.json |
Pins SDK 10.0.404 while preserving strict version selection. |
docs/plans/2026-11-06-configuration-validation.md |
Updates the documented SDK version. |
CHANGELOG.md |
Records the coordinated toolchain upgrade. |
.oss-scanner/Dockerfile |
Aligns the scanner image tag and digest with the SDK pin. |
.github/workflows/Validate-Packages.yml |
Uses SDK 10.0.404 for package validation. |
.github/workflows/Upstream-Compatibility.yml |
Updates three SDK selections to 10.0.404. |
Review effort: Balanced
Up to standards ✅🟢 Issues
|
|
Follow-up to Copilot's validation concern: the scanner image build and network-disabled acceptance now pass, along with the Build gate, all nine runtime/OS cells, all three full OS builds, package validation, and local BuildCrossPlatform (17 tasks, zero errors/warnings). Evidence links and exact local commands/results are in the updated PR body. Copilot and Codex reported no code findings. This PR is NOT ready to merge: live Upstream Compatibility reports conflict/scenario/evidence fingerprint drift across all nine profiles. I have not refreshed baselines or weakened gates; the compatibility evidence needs separate reviewed adjudication. |
Pull Request
Description
Summary
Coordinated upgrade from the 3xx to 4xx SDK feature band: update global.json, the scanner tag/digest, all four hard-coded workflow SDK selections, and the documentation reference/changelog. No module runtime or NuGet package changes.
This supersedes the image-only update in #331 without modifying or closing it manually. Dependabot should close #331 automatically once main contains this update.
Evidence
4ab9ae20fails offline scanner setup because global.json requires 10.0.302; its Build gate consequently fails. Its module matrix passed; Dependency Review's no-snapshot/no-scanned-files result is not image-advisory evidence.dotnet --versionpassed:10.0.404.dotnet restore .\src\DLLPickle.Build\DLLPickle.csproj --locked-modepassed.dotnet build .\src\DLLPickle.Build\DLLPickle.csproj --configuration Release --no-restorepassed for net8.0/net9.0/net10.0 with zero warnings/errors.pwsh -NoLogo -NoProfile -NonInteractive -File .\tools\Invoke-DLLPickleBuild.ps1 -Task BuildCrossPlatformpassed: 17 tasks, zero errors/warnings, including formatting, PSScriptAnalyzer, isolated Pester unit tests (67.20% coverage), locked restore, compilation, packaging and archive.pwsh -NoLogo -NoProfile -NonInteractive -File .\tools\Invoke-DLLPickleBuild.ps1 -Task Buildfailed because the standalone packaging task lacked initialized artifact output; it is not the full build task graph. The subsequent complete graph above passed.curl.exe --fail --silent --show-error --retry 2 -D - -H 'Accept: application/vnd.docker.distribution.manifest.list.v2+json' 'https://mcr.microsoft.com/v2/dotnet/sdk/manifests/10.0.404-noble'passed (HTTP 200); officialDocker-Content-Digestissha256:fe0fd4e93bd2fbb47c883b7a6369e5c8d3db8bf01cdc5981f6ee35fbdf3ff4fb(includes Linux amd64).git diff --checkpassed; repository-wide tracked-file search found no remaining10.0.302references.Not ready to merge: Upstream Compatibility is red. All nine live profile evidence cells report conflict/scenario/evidence fingerprint drift against committed baselines; the aggregate and stable tooling gate fail as a consequence. Its deterministic implementation-validation job passed. This is separate from the now-passing scanner SDK mismatch. No compatibility baseline was refreshed and no gate was relaxed. Resolving this requires reviewed upstream-compatibility adjudication. Recent scheduled main runs are also red, but for skipped evidence jobs; that alone does not establish an identical failure.
Reviews: Copilot completed with no open code issues, flagging the then-missing full CI/offline evidence (now linked above). Codex completed on
35f9a3fwith no findings. CodeRabbit completed without inline change requests. No review suggestions required a code change; no merge has been performed.Merge Danger
Door: two-way
Revert the SDK selections and scanner tag/digest together if needed; do not relax exact SDK matching.
Blast Radius: toolchain
New SDK feature band affects builds, not the declared PowerShell/.NET runtime support profiles. Existing full CI and offline scanner acceptance remain required before merging. Upstream compatibility evidence is still blocking readiness.
Type of Change
Issue Resolved
Closes #333. Related: #331.
Automated Checks
The following checks run automatically and must pass before this PR can be merged:
packages.lock.jsonChecklist
Testing
If possible, we kindly ask that Pester tests be added for any new or changed functionality.
No new functions or runtime behavior are introduced; existing build, scanner exact-match checks, and unit tests exercise the aligned configuration. The checkbox refers to the unit/build/offline test suites; the separate live upstream-evidence policy gate remains red as documented above.
Summary by CodeRabbit