Skip to content

build: align exact .NET SDK and scanner pins on 10.0.404 - #334

Open
SamErde wants to merge 1 commit into
mainfrom
samerde-sdk-pin-alignment
Open

SamErde wants to merge 1 commit into
mainfrom
samerde-sdk-pin-alignment

Conversation

@SamErde

@SamErde SamErde commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Pull Request

Description

Summary

- SDK policy / CI: 10.0.302; scanner-only update in #331: 10.0.404
+ SDK policy / CI / scanner: 10.0.404
  rollForward: disable
  allowPrerelease: false

Coordinated upgrade from the 3xx to 4xx SDK feature band: update global.json, the scanner tag/digest, all four hard-coded workflow SDK selections, and the documentation reference/changelog. No module runtime or NuGet package changes.

This supersedes the image-only update in #331 without modifying or closing it manually. Dependabot should close #331 automatically once main contains this update.

Evidence

  • Before: ci: bump dotnet/sdk from 10.0.302-noble to 10.0.404-noble in /.oss-scanner #331 at 4ab9ae20 fails offline scanner setup because global.json requires 10.0.302; its Build gate consequently fails. Its module matrix passed; Dependency Review's no-snapshot/no-scanned-files result is not image-advisory evidence.
  • After: scanner image build and network-disabled acceptance passed. The Build Module run passed the Build gate, all three full OS builds, and all nine exact-runtime/OS cells. Package validation and Dependency Review passed. Codacy, CodeQL, CodeFactor, GitGuardian and CodeRabbit passed.
  • dotnet --version passed: 10.0.404.
  • dotnet restore .\src\DLLPickle.Build\DLLPickle.csproj --locked-mode passed.
  • dotnet build .\src\DLLPickle.Build\DLLPickle.csproj --configuration Release --no-restore passed for net8.0/net9.0/net10.0 with zero warnings/errors.
  • pwsh -NoLogo -NoProfile -NonInteractive -File .\tools\Invoke-DLLPickleBuild.ps1 -Task BuildCrossPlatform passed: 17 tasks, zero errors/warnings, including formatting, PSScriptAnalyzer, isolated Pester unit tests (67.20% coverage), locked restore, compilation, packaging and archive.
  • The initially attempted pwsh -NoLogo -NoProfile -NonInteractive -File .\tools\Invoke-DLLPickleBuild.ps1 -Task Build failed because the standalone packaging task lacked initialized artifact output; it is not the full build task graph. The subsequent complete graph above passed.
  • MCR verification: curl.exe --fail --silent --show-error --retry 2 -D - -H 'Accept: application/vnd.docker.distribution.manifest.list.v2+json' 'https://mcr.microsoft.com/v2/dotnet/sdk/manifests/10.0.404-noble' passed (HTTP 200); official Docker-Content-Digest is sha256:fe0fd4e93bd2fbb47c883b7a6369e5c8d3db8bf01cdc5981f6ee35fbdf3ff4fb (includes Linux amd64).
  • git diff --check passed; repository-wide tracked-file search found no remaining 10.0.302 references.
  • Docker is unavailable on the local Windows host; offline acceptance evidence comes from CI, not a local Docker run. Codacy MCP tools are unavailable locally, so Codacy CLI analysis was not run; the hosted Codacy check passed.

Not ready to merge: Upstream Compatibility is red. All nine live profile evidence cells report conflict/scenario/evidence fingerprint drift against committed baselines; the aggregate and stable tooling gate fail as a consequence. Its deterministic implementation-validation job passed. This is separate from the now-passing scanner SDK mismatch. No compatibility baseline was refreshed and no gate was relaxed. Resolving this requires reviewed upstream-compatibility adjudication. Recent scheduled main runs are also red, but for skipped evidence jobs; that alone does not establish an identical failure.

Reviews: Copilot completed with no open code issues, flagging the then-missing full CI/offline evidence (now linked above). Codex completed on 35f9a3f with no findings. CodeRabbit completed without inline change requests. No review suggestions required a code change; no merge has been performed.

Merge Danger

Door: two-way

Revert the SDK selections and scanner tag/digest together if needed; do not relax exact SDK matching.

Blast Radius: toolchain

New SDK feature band affects builds, not the declared PowerShell/.NET runtime support profiles. Existing full CI and offline scanner acceptance remain required before merging. Upstream compatibility evidence is still blocking readiness.

Type of Change

  • 📖 Documentation
  • 🪲 Fix
  • 🩹 Patch
  • ⚠️ Security Fix
  • 🚀 Feature
  • 💥 Breaking Change

Issue Resolved

Closes #333. Related: #331.

Automated Checks

The following checks run automatically and must pass before this PR can be merged:

  • Build Module — matrix across Windows, Linux, and macOS; runs PSScriptAnalyzer (default rules + OTBS formatting + PS 5.1 compatibility), Pester unit tests (≥30% coverage), and full module build
  • Dependency Review — blocks PRs introducing dependencies with known vulnerabilities (moderate severity or higher)
  • Validate .NET Packages — NuGet lock file is enforced; resolved packages must match packages.lock.json

Checklist

  • I have reviewed my code for errors and tested it.
  • My pull request does not contain multiple types of changes.
  • My code follows the code style of this project.
  • I have updated the documentation as necessary.
  • I have read the CONTRIBUTING document.

Testing

If possible, we kindly ask that Pester tests be added for any new or changed functionality.

  • I have added tests to cover my changes.
  • All new and existing tests passed.

No new functions or runtime behavior are introduced; existing build, scanner exact-match checks, and unit tests exercise the aligned configuration. The checkbox refers to the unit/build/offline test suites; the separate live upstream-evidence policy gate remains red as documented above.

Summary by CodeRabbit

  • Chores
    • Updated build, package validation, and compatibility checks to use .NET SDK 10.0.404.
    • Updated the open-source scanner image to the matching SDK release.
  • Documentation
    • Updated the changelog and configuration-validation plan to reflect the SDK version change.

Preserve exact SDK selection and align CI and documentation references. Verified the scanner manifest-list digest against official MCR metadata.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 15:45
@SamErde

SamErde commented Nov 16, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The repository’s .NET SDK pin changes from 10.0.302 to 10.0.404. The workflows and scanner image use the updated version, and the changelog and validation plan reflect the change.

Changes: SDK version alignment

Layer / File(s) Summary
Update SDK configuration and CI selections
global.json, .github/workflows/Upstream-Compatibility.yml, .github/workflows/Validate-Packages.yml, docs/plans/2026-11-06-configuration-validation.md
The global SDK pin and workflow selections change to 10.0.404. The validation plan records the updated pin.
Align scanner image
.oss-scanner/Dockerfile, CHANGELOG.md
The scanner image changes to the .NET SDK 10.0.404 Noble image and its corresponding digest. The changelog records the alignment.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other · Severity of issue fixed: Medium

Possibly related PRs

  • SamErde/DLLPickle#319: Adds the offline scanner environment and defines the scanner image and workflow that this PR updates.

Suggested labels: Workflows, documentation, Build

Merge Risk: Minimal · up to 35f9a

This change moves the pinned .NET SDK and scanner image to 10.0.404 across configuration, CI and docs. No concrete defects were found. Confirm that the full CI run and the offline scanner acceptance job pass before merging.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "build: align exact .NET SDK and scanner pins on 10.0.404" matches the main change. The PR moves the global.json SDK pin, the scanner image tag and digest, the workflow SDK selections, and t…
Linked Issues check Passed Directly linked issues #333 and #331 require the same exact SDK version, 10.0.404, across the scanner image, global.json, and CI SDK selections, with strict selection retained. At reviewed head 35f9a3…
Out of Scope Changes check Passed All changed files are SDK pin alignments or their documentation: global.json, .oss-scanner/Dockerfile, two workflow files (three and one SDK selections), docs/plans/2026-11-06-configuration-validation…
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "build: align exact .NET SDK and scanner pins on 10.0.404" matches the main change. The PR moves the global.json SDK pin, the scanner image tag and digest, the workflow SDK selections, and the docs from 10.0.302 to 10.0.404. The title is specific, short, and follows a conventional commit style.

Full details: Linked Issues check

Explanation

Directly linked issues #333 and #331 require the same exact SDK version, 10.0.404, across the scanner image, global.json, and CI SDK selections, with strict selection retained. At reviewed head 35f9a3f: (1) global.json sets sdk.version to 10.0.404 with rollForward disable and allowPrerelease false, as #333 requires. (2) .oss-scanner/Dockerfile uses mcr.microsoft.com/dotnet/sdk:10.0.404-noble@sha256:fe0fd4e9..., the digest named in #331 and #333. The Dockerfile comment states that setup.ps1 checks the exact version. (3) The PR summary reports the four workflow SDK selections changed from 10.0.302 to 10.0.404 (Upstream-Compatibility.yml x3, Validate-Packages.yml x1). I did not read these workflow hunks directly; this finding rests on the whole-PR summary. (4) The PR summary reports no remaining tracked 10.0.302 references, and the docs plan file is updated. Automated coverage for the SDK pin is existing build and exact-match checks; #333 does not require new tests. Local Docker and offline scanner acceptance were not run and are deferred to CI, which is a verification step, not a missing code requirement. #331 is not modified manually, as #333 requires.

Full details: Out of Scope Changes check

Explanation

All changed files are SDK pin alignments or their documentation: global.json, .oss-scanner/Dockerfile, two workflow files (three and one SDK selections), docs/plans/2026-11-06-configuration-validation.md, and a CHANGELOG.md Unreleased entry. The PR states no module runtime, NuGet package, or public API changes. Each change ties directly to #333's requirement to align active SDK references and document them. The workflow hunks were confirmed only from the summary, not from the diff. No unrelated change was found.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1e1b6e24-0b9e-4adf-9d06-0cbf1f8038b0
Commits

Reviewing files that changed from the base of the PR and between 174e515 and 35f9a3f.

Files selected for processing: 6

  • .github/workflows/Upstream-Compatibility.yml
  • .github/workflows/Validate-Packages.yml
  • .oss-scanner/Dockerfile
  • CHANGELOG.md
  • docs/plans/2026-11-06-configuration-validation.md
  • global.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T15:46:17.681652Z 35f9a3f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 35f9a3fa52

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions github-actions Bot added documentation Improvements or additions to documentation Workflows labels Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

  • src/DLLPickle.Build/DLLPickle.csproj

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The supplied evidence lacks successful full CI and network-disabled Docker scanner acceptance results, leaving SDK feature-band image/runtime compatibility unresolved by static review alone.

No open issues 🎉

What changed in this PR

Aligns DLLPickle’s build toolchain and offline scanner on .NET SDK 10.0.404, addressing the exact-version mismatch described in #333 and superseding the image-only update in #331. Runtime support and NuGet packages remain unchanged.

Changes:

  • Updates the SDK pin and scanner image tag/digest together, retaining disabled roll-forward and prerelease selection.
  • Aligns all four hard-coded CI SDK selections.
  • Updates the configuration reference and changelog.
File Description
global.json Pins SDK 10.0.404 while preserving strict version selection.
docs/​plans/​2026-11-06-configuration-validation.md Updates the documented SDK version.
CHANGELOG.md Records the coordinated toolchain upgrade.
.oss-scanner/​Dockerfile Aligns the scanner image tag and digest with the SDK pin.
.github/​workflows/​Validate-Packages.yml Uses SDK 10.0.404 for package validation.
.github/​workflows/​Upstream-Compatibility.yml Updates three SDK selections to 10.0.404.

Review effort: Balanced

@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@SamErde

SamErde commented Nov 16, 2026

Copy link
Copy Markdown
Owner Author

Follow-up to Copilot's validation concern: the scanner image build and network-disabled acceptance now pass, along with the Build gate, all nine runtime/OS cells, all three full OS builds, package validation, and local BuildCrossPlatform (17 tasks, zero errors/warnings). Evidence links and exact local commands/results are in the updated PR body. Copilot and Codex reported no code findings. This PR is NOT ready to merge: live Upstream Compatibility reports conflict/scenario/evidence fingerprint drift across all nine profiles. I have not refreshed baselines or weakened gates; the compatibility evidence needs separate reviewed adjudication.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align .NET SDK pins with the offline scanner image upgrade to 10.0.404

2 participants