Fix PBO path resolution - #227
Open
bjoern-sobolewski wants to merge 1 commit into
Open
bjoern-sobolewski wants to merge 1 commit into
bjoern-sobolewski wants to merge 1 commit into
Conversation
Support paths with a leading slash and make PBO path lookup case-insensitive to match Arma3 behavior. Check both the archive and member name when detecting recursive includes so files in the same PBO can include one another. Fix the filename shown in read errors and return a nonzero CLI exit code when an archive cannot be opened or a member read fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support paths with a leading slash and make PBO path lookup case-insensitive to match Arma3 behavior.
Check both the archive and member name when detecting recursive includes so files in the same PBO can include one another.
Fix the filename shown in read errors and return a nonzero CLI exit code when an archive cannot be opened or a member read fails.
Tested on Windows x64. Also checked rooted, unrooted and mixed-case include paths against Arma3's ui_f.pbo.