Skip to content

Apply deployment branding across the Angular UI - #92

Merged
kflemin merged 10 commits into
mainfrom
override-look
Oct 1, 2026
Merged

kflemin merged 10 commits into
mainfrom
override-look

Conversation

@kflemin

@kflemin kflemin commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

New: Apply custom deployment branding across the UI

  • When enabled via environment variables, use deployment branding on login, splash screen, left navigation, and custom dashboard.
  • Render custom dashboard hero images at full width without cropping.
  • Implement dashboard page fully (most of the functionality of the old UI is there expect for sample data uploading)
  • Support deployment-hidden navigation and hide/block disabled Salesforce and BETTER features.
  • Remove “NLR” from the Data Terms consent label and error text.
  • Fix the sidebar dense-mode toggle so it collapses after a click.

@kflemin kflemin added the feature New functionality label Sep 30, 2026
@kflemin
kflemin requested a balanced review from Copilot September 30, 2026 20:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Disabled Salesforce surfaces remain accessible, valid empty-measure scenarios are hidden, and new accessibility/localization gaps need correction.

Review effort: Balanced
Findings: 1 High severity · 5 Medium severity · 1 Low severity

Open (7)
What changed in this PR

Applies deployment branding and feature controls across the Angular UI while expanding the dashboard and scenario presentation.

Changes:

  • Adds configurable branding, navigation visibility, and integration gating.
  • Implements the dashboard workflow, dataset creation shortcut, and sidebar fix.
  • Expands scenario/measure details and translations.

Validation: GitHub lint/build check passed.

File Description
proxy.conf.mjs Proxies branding and static assets.
public/​i18n/​en_US.json Adds scenario translations.
public/​i18n/​es.json Adds Spanish translations.
public/​i18n/​fr_CA.json Adds French translations.
public/​images/​kc_2.webp Adds dashboard hero image.
src/​@seed/​api/​config/​config.types.ts Types deployment configuration.
src/​@seed/​api/​scenario/​scenario.types.ts Expands scenario and measure types.
src/​app/​app.config.ts Initializes branded splash logo.
src/​app/​app.routes.ts Resolves configuration for authenticated routes.
src/​app/​core/​navigation/​navigation.service.ts Filters deployment-hidden navigation.
src/​app/​layout/​layouts/​landing/​landing.component.html Renders branded login content.
src/​app/​layout/​layouts/​landing/​landing.component.ts Exposes configuration to landing layout.
src/​app/​layout/​layouts/​main/​main.component.html Displays branded navigation logo and toggle labels.
src/​app/​layout/​layouts/​main/​main.component.spec.ts Tests dense navigation behavior.
src/​app/​layout/​layouts/​main/​main.component.ts Applies branding and hidden navigation.
src/​app/​modules/​auth/​sign-in/​sign-in.component.html Updates Data Terms wording.
src/​app/​modules/​auth/​sign-up/​sign-up.component.html Updates Data Terms wording.
src/​app/​modules/​datasets/​datasets.component.ts Supports query-triggered dataset creation.
src/​app/​modules/​insights/​portfolio-summary/​portfolio-summary.component.html Gates Salesforce controls.
src/​app/​modules/​insights/​portfolio-summary/​portfolio-summary.component.spec.ts Tests disabled Salesforce verification.
src/​app/​modules/​insights/​portfolio-summary/​portfolio-summary.component.ts Reads deployment Salesforce state.
src/​app/​modules/​inventory-detail/​detail/​grid/​scenarios-grid.component.html Expands scenario and measure presentation.
src/​app/​modules/​inventory-detail/​detail/​grid/​scenarios-grid.component.ts Adds rollups, formatting, and status handling.
src/​app/​modules/​inventory-detail/​detail/​header.component.ts Gates Salesforce inventory action.
src/​app/​modules/​inventory-list/​list/​modal/​more-actions-modal.component.ts Hides Salesforce bulk action.
src/​app/​modules/​inventory/​actions/​analysis-run-modal.component.ts Hides disabled BETTER analysis.
src/​app/​modules/​main/​home/​home.component.html Implements default and custom dashboards.
src/​app/​modules/​main/​home/​home.component.ts Supplies dashboard user/config state.
src/​app/​modules/​organizations/​settings/​api-keys/​api-keys.component.html Hides disabled BETTER settings.
src/​app/​modules/​organizations/​settings/​api-keys/​api-keys.component.ts Disables BETTER validation when unavailable.
src/​app/​modules/​organizations/​settings/​settings.component.ts Removes Salesforce settings navigation.
src/​index.html Defers splash-logo visibility until configured.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +252 to +254
// Only PackageOfMeasures scenarios are meaningful here; scenario type isn't stored, so measures are the proxy
getScenariosWithMeasures(scenarios: Scenario[]): Scenario[] {
return (scenarios ?? []).filter((scenario) => scenario.measures?.length)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the measure-list filter so valid package-level scenarios without measures remain visible. Commit: a7644ab.

Comment on lines +32 to +33
[attr.aria-label]="navigationAppearance === 'default' ? 'Collapse navigation' : 'Expand navigation'"
[title]="navigationAppearance === 'default' ? 'Collapse navigation' : 'Expand navigation'"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localized the toggle’s accessible label and tooltip with the existing Transloco Collapse and Expand keys. Commit: 8404462.

Comment on lines +74 to +76
<span>I agree with the&nbsp;</span>
<a class="cursor-pointer text-primary-500 hover:underline focus:underline" (click)="$event.preventDefault(); showTermsOfService()"
>Data Terms</a

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localized the consent phrase, Data Terms link, and validation message through Transloco, and added the corresponding keys to all three locale bundles. Commit: beb1db2.

Comment on lines +64 to +66
<span>I agree with the&nbsp;</span>
<a class="cursor-pointer text-primary-500 hover:underline focus:underline" (click)="$event.preventDefault(); showTermsOfService()"
>Data Terms</a

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localized the sign-up Data Terms label and validation message through Transloco and added the English source keys in commit 3915dad. The push was rejected because this branch is protected; the change is committed locally but is not on the PR yet.

Comment thread src/app/modules/organizations/settings/settings.component.ts
Comment thread src/app/layout/layouts/main/main.component.html Outdated
Co-authored-by: kflemin <2205659+kflemin@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: kflemin <2205659+kflemin@users.noreply.github.com>
@kflemin

kflemin commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

# Conflicts:
#	src/app/modules/inventory-detail/detail/grid/scenarios-grid.component.ts

Co-authored-by: kflemin <2205659+kflemin@users.noreply.github.com>

Copilot AI commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Merged main and resolved the scenario-grid conflict, preserving scenarios without measures. Merge commit: 2857cb5.

@kflemin
kflemin merged commit 976c924 into main Oct 1, 2026
2 checks passed
@kflemin
kflemin deleted the override-look branch October 1, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants