Repository navigation
Apply deployment branding across the Angular UI - #92
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Disabled Salesforce surfaces remain accessible, valid empty-measure scenarios are hidden, and new accessibility/localization gaps need correction.
Review effort: Balanced
Findings: 1
Open (7)
Empty-measure package scenarios are incorrectly filtered · New Navigation labels bypass localization · New Sign-in consent text is not localized · New Sign-up consent text is not localized · New Disabled Salesforce still appears in goal dialogs · New Disabled Salesforce routes remain directly accessible · New Custom logo dashboard link lacks accessible name · New
What changed in this PR
Applies deployment branding and feature controls across the Angular UI while expanding the dashboard and scenario presentation.
Changes:
- Adds configurable branding, navigation visibility, and integration gating.
- Implements the dashboard workflow, dataset creation shortcut, and sidebar fix.
- Expands scenario/measure details and translations.
Validation: GitHub lint/build check passed.
| File | Description |
|---|---|
proxy.conf.mjs |
Proxies branding and static assets. |
public/i18n/en_US.json |
Adds scenario translations. |
public/i18n/es.json |
Adds Spanish translations. |
public/i18n/fr_CA.json |
Adds French translations. |
public/images/kc_2.webp |
Adds dashboard hero image. |
src/@seed/api/config/config.types.ts |
Types deployment configuration. |
src/@seed/api/scenario/scenario.types.ts |
Expands scenario and measure types. |
src/app/app.config.ts |
Initializes branded splash logo. |
src/app/app.routes.ts |
Resolves configuration for authenticated routes. |
src/app/core/navigation/navigation.service.ts |
Filters deployment-hidden navigation. |
src/app/layout/layouts/landing/landing.component.html |
Renders branded login content. |
src/app/layout/layouts/landing/landing.component.ts |
Exposes configuration to landing layout. |
src/app/layout/layouts/main/main.component.html |
Displays branded navigation logo and toggle labels. |
src/app/layout/layouts/main/main.component.spec.ts |
Tests dense navigation behavior. |
src/app/layout/layouts/main/main.component.ts |
Applies branding and hidden navigation. |
src/app/modules/auth/sign-in/sign-in.component.html |
Updates Data Terms wording. |
src/app/modules/auth/sign-up/sign-up.component.html |
Updates Data Terms wording. |
src/app/modules/datasets/datasets.component.ts |
Supports query-triggered dataset creation. |
src/app/modules/insights/portfolio-summary/portfolio-summary.component.html |
Gates Salesforce controls. |
src/app/modules/insights/portfolio-summary/portfolio-summary.component.spec.ts |
Tests disabled Salesforce verification. |
src/app/modules/insights/portfolio-summary/portfolio-summary.component.ts |
Reads deployment Salesforce state. |
src/app/modules/inventory-detail/detail/grid/scenarios-grid.component.html |
Expands scenario and measure presentation. |
src/app/modules/inventory-detail/detail/grid/scenarios-grid.component.ts |
Adds rollups, formatting, and status handling. |
src/app/modules/inventory-detail/detail/header.component.ts |
Gates Salesforce inventory action. |
src/app/modules/inventory-list/list/modal/more-actions-modal.component.ts |
Hides Salesforce bulk action. |
src/app/modules/inventory/actions/analysis-run-modal.component.ts |
Hides disabled BETTER analysis. |
src/app/modules/main/home/home.component.html |
Implements default and custom dashboards. |
src/app/modules/main/home/home.component.ts |
Supplies dashboard user/config state. |
src/app/modules/organizations/settings/api-keys/api-keys.component.html |
Hides disabled BETTER settings. |
src/app/modules/organizations/settings/api-keys/api-keys.component.ts |
Disables BETTER validation when unavailable. |
src/app/modules/organizations/settings/settings.component.ts |
Removes Salesforce settings navigation. |
src/index.html |
Defers splash-logo visibility until configured. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // Only PackageOfMeasures scenarios are meaningful here; scenario type isn't stored, so measures are the proxy | ||
| getScenariosWithMeasures(scenarios: Scenario[]): Scenario[] { | ||
| return (scenarios ?? []).filter((scenario) => scenario.measures?.length) |
There was a problem hiding this comment.
Removed the measure-list filter so valid package-level scenarios without measures remain visible. Commit: a7644ab.
| [attr.aria-label]="navigationAppearance === 'default' ? 'Collapse navigation' : 'Expand navigation'" | ||
| [title]="navigationAppearance === 'default' ? 'Collapse navigation' : 'Expand navigation'" |
There was a problem hiding this comment.
Localized the toggle’s accessible label and tooltip with the existing Transloco Collapse and Expand keys. Commit: 8404462.
| <span>I agree with the </span> | ||
| <a class="cursor-pointer text-primary-500 hover:underline focus:underline" (click)="$event.preventDefault(); showTermsOfService()" | ||
| >Data Terms</a |
There was a problem hiding this comment.
Localized the consent phrase, Data Terms link, and validation message through Transloco, and added the corresponding keys to all three locale bundles. Commit: beb1db2.
| <span>I agree with the </span> | ||
| <a class="cursor-pointer text-primary-500 hover:underline focus:underline" (click)="$event.preventDefault(); showTermsOfService()" | ||
| >Data Terms</a |
There was a problem hiding this comment.
Localized the sign-up Data Terms label and validation message through Transloco and added the English source keys in commit 3915dad. The push was rejected because this branch is protected; the change is committed locally but is not on the PR yet.
Co-authored-by: kflemin <2205659+kflemin@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: kflemin <2205659+kflemin@users.noreply.github.com>
|
@copilot resolve the merge conflicts in this pull request |
# Conflicts: # src/app/modules/inventory-detail/detail/grid/scenarios-grid.component.ts Co-authored-by: kflemin <2205659+kflemin@users.noreply.github.com>
Merged |



New: Apply custom deployment branding across the UI