Repository navigation
Add ability to pin columns in a col list profile - #102
Merged
Merged
Conversation
kflemin
commented
Oct 23, 2026
kflemin
commented
Contributor
- Restore drag-and-drop ordering and add keyboard-editable order in the profile editor.
- Add pin/unpin controls for list profiles and persist each column’s order and pinned state.
- Apply saved profile order and pins to the inventory grid.
- NEW: allow pinning of derived columns
- Add regression tests for profile editing and inventory grid behavior.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Save-response races, stale pin callbacks, and keyboard-inaccessible pin controls remain unresolved.
3 open issues
What changed in this PR
Adds saved column ordering and pinning to SEED’s profile editor and applies those settings to the inventory grid.
Changes:
- Restores drag ordering and adds numeric order editing and pin controls, including support for derived columns.
- Preserves profile order and pinned state when saving and displaying inventory.
- Adds regression tests, translated labels, and wrapping editor controls.
Validation was limited to targeted source inspection; tests and live-browser checks were not run.
| File | Description |
|---|---|
src/app/modules/inventory-list/list/inventory.component.ts |
Applies saved profile order and pins to grid columns. |
src/app/modules/inventory-list/list/inventory.component.spec.ts |
Tests profile mapping and no-profile behavior. |
src/@seed/components/column-profiles/column-profiles.component.ts |
Implements ordering, pinning, selection synchronization, and saving. |
src/@seed/components/column-profiles/column-profiles.component.spec.ts |
Tests profile editing and saved column settings. |
src/@seed/components/column-profiles/column-profiles.component.html |
Allows editor controls to wrap. |
public/i18n/fr_CA.json |
Adds French ordering and pin labels. |
public/i18n/es.json |
Adds Spanish ordering and pin labels. |
public/i18n/en_US.json |
Adds English labels and removes a duplicate key. |
Review effort: Balanced
| sortable: false, | ||
| filter: false, | ||
| resizable: false, | ||
| cellRenderer: this.profileType === 'list' ? this.pinRenderer : undefined, |
Contributor
There was a problem hiding this comment.
Added Enter/Space activation for the focused pin cell and suppresses conflicting grid shortcuts. Covered both keys in tests. Commit: 686c9d9.
Update currentProfile only if it matches the updated profile. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: kflemin <2205659+kflemin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.