Skip to content

Fix DAC highlighting on the inventory map - #101

Merged
kflemin merged 1 commit into
mainfrom
bug/map-fixes
Oct 19, 2026
Merged

kflemin merged 1 commit into
mainfrom
bug/map-fixes

Conversation

@axelstudios

@axelstudios axelstudios commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Any background context you want to provide?

DAC highlights weren’t updating until the map was moved, both on initial load and after toggling the setting.

What's this PR do?

  • Fixes initial highlighting and makes toggle changes show up immediately
  • Makes tract highlights translucent rather than opaque so that the map is still visible
  • Fades the Highlight DACs toggle when Census Tracts is disabled
  • Adds regression tests for loading, toggling, caching, and disabled styling
  • Adds testing to the CI

How should this be manually tested?

  1. Open the inventory map in an area with known DACs and zoom in until census tracts appear. Highlights should show without another pan or zoom.
  2. Toggle Highlight DACs off/on. The fill should update immediately and remain translucent.
  3. Turn Census Tracts off/on. Highlight DACs should become disabled and faded, then restore its previous selection.

@axelstudios
axelstudios requested a review from kflemin October 19, 2026 20:08
@kflemin
kflemin merged commit e9660f7 into main Oct 19, 2026
2 checks passed
@kflemin
kflemin deleted the bug/map-fixes branch October 19, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants