Repository navigation
[ryoku] shell: stop churning two full-screen surfaces - #549
Merged
neur0map merged 4 commits intoOct 25, 2026
Merged
Conversation
The desktop frost built a full-output layer and blur chain each time a workspace filled and tore it down again when it emptied. Keep the layer once the glass has shown and drive only the blur amount, dropping it when the glass cannot show at all (frost off, blur disabled, moving wallpaper, Gokko or the Stage Editor). Refs #222 Note: Fixed: switching between empty and busy workspaces no longer rebuilds the desktop frost blur each time
Under every bar style but Sumi the ryoku-frame overlay only hosts menus and popouts, yet it stayed mapped full-screen at all times. Map it while Sumi is active, or while a menu, surface, plugin popout, dock preview or music card is on screen, closing animation included. Refs #223 Note: Fixed: the shell no longer keeps an invisible full-screen menu layer mapped under non-Sumi bar styles
The frame overlay now maps on demand outside Sumi, so the compositor's layer animation would move the whole full-output surface on top of the QML melt. The frost layer is also gated on the glass being possible, so it can never outlive the states that need it. Note: Fixed: Menus no longer animate twice when opening outside Sumi
itsKontra
force-pushed
the
perf/shell-fullscreen-surfaces
branch
from
October 25, 2026 12:37
af0e61d to
0b1528d
Compare
Member
|
Thanks for the work here, this ships in the next v1 release. |
This was referenced Oct 25, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Two full-output surfaces stop costing GPU work and memory when they show nothing.
blur. It no longer creates and destroys a full-screen FBO on every switch between an empty and a busy workspace. The layer is released only when the glass cannot show at all.ryoku-frame: outside Sumi, the overlay maps only while a menu, surface, plugin popout, dock preview or music card is on screen, closing animations included (FrameMenuManager.anyShowing).ryoku-frame-noanim, so the compositor does not animate the overlay on top of the QML transitions now that it maps on demand.Trade-off: once a busy workspace has been visited, the frost layer stays resident.
Fixes itsKontra#222, itsKontra#223
Estimated improvement
Outside Sumi, about 50 MB of VRAM comes back while no menu is open. A switch between an empty and a busy workspace no longer allocates a 2560×1440 FBO and blur chain. The 180 ms fade still redraws. The before figures come from the issue; the after is an estimate, not measured.
Area
ryoku
How it was tested
qmllintmatches the warnings from before, apart from two newmissing-propertywarnings of a kind these files already get.decoration.luaparses (luajit -bl).ryoku-frameis absent from the layer list at rest; every menu, prompt and popout opens and closes cleanly; the first menu after login lands at the right size; niri does not animate the layer map.Checklist
[area] scope: summarycommit subject.CHANGELOG.mdupdated in the area I touched.--no-verify.luac -p), shell scripts passbash -n, and QML passesqmllintwhere applicable.