Repository navigation
ABI check: recognise compatibility packages that also require the mutex - #69
Merged
Merged
Conversation
RoboStack/vinca#171 makes each ros-<distro>-<pkg> alias depend on its distribution's mutex as well as on ros2-<pkg> ==<version>; the check counted exactly one dependency and would treat such aliases as real packages. Both forms are accepted, so this can merge before the vinca pin moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RoboStack/vinca#171 makes each
ros-<distro>-<pkg>compatibility package depend on its distribution's mutex as well as onros2-<pkg> ==<version>, so that it can't resolve to another distribution's build in a shared channel.tools/abi_check.pyrecognised these packages by "exactly one dependency". Once the vinca pin includes #171, it would treat the new aliases as real packages. It now acceptsros2-<pkg> ==<version>followed only byros2-distro-mutexdependencies. The old form still works, so this can merge before the vinca pin moves.A test covers both forms and two look-alikes that must not match.
pixi run test: 13 passed.🤖 Generated with Claude Code