Repository navigation
Add rko_lio - #119
Draft
Tobias-Fischer wants to merge 2 commits into
Draft
Add rko_lio#119Tobias-Fischer wants to merge 2 commits into
Tobias-Fischer wants to merge 2 commits into
Conversation
Ports RoboStack/ros-kilted#104: rko_lio (PRBonn's KISS-ICP-based LiDAR-inertial odometry). It's released as 0.4.2 in humble, jazzy, lyrical and rolling, so no additional recipe is needed. Maps robin-map-dev to conda-forge's tsl_robin_map, and drops rko_lio's Eigen 3.4 minimum version, which Eigen 5's config (SameMajorVersion) rejects. Co-authored-by: Sattwik Kumar Sahu <98335434+sattwik-sahu@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Turns the local checks of this PR into a recipe test, so later rebuilds keep them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports RoboStack/ros-kilted#104 by @sattwik-sahu: adds
rko_lio(PRBonn's KISS-ICP-based LiDAR-inertial odometry) to the shared selection.rko_lio0.4.2 is released in the humble, jazzy, lyrical and rolling rosdistros, so the PR's additional recipe (0.4.0) isn't needed.robostack.yaml:robin-map-dev→ conda-forgetsl_robin_map(as in the PR).shared/patch/ros2-rko-lio.patch:find_package(Eigen3 3.4 REQUIRED CONFIG)without the minimum version. Eigen 5's config (SameMajorVersion) rejects a 3.x request; kilted didn't notice because it's still on Eigen 3.4.Recipe test:
online_nodestarts and keeps running (shared/tests/ros2-rko-lio.yaml).Built locally
rko_lioincl. its recipe test; installed,online_node,offline_nodeandonline_imu_rate_nodestart.rko_lioincl. its recipe test.tsl_robin_mapfor win-64).Prepared on top of the current rosdistro syncs (#62 humble, #61 jazzy, #60 lyrical, #99 rolling). CI is held with
[skip ci]; merge after them.🤖 Generated with Claude Code