Repository navigation
Add canopen (Linux) - #111
Open
Tobias-Fischer wants to merge 3 commits into
Open
Tobias-Fischer wants to merge 3 commits into
Tobias-Fischer wants to merge 3 commits into
Conversation
Ports RoboStack/ros-jazzy#167: lely_core_libraries installs the lely-core autotools build into the prefix from its own build directory (refreshed for 0.3.4; humble's 0.2.13 keeps the original patch). The glibc 2.28 the PR needed is already the pinning. Co-authored-by: Marc Bestmann <11520148+SammyRamone@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tobias-Fischer
marked this pull request as ready for review
October 19, 2026 01:42
humble's lely_core_libraries 0.2.13 builds an older lely commit (fb735b79), and GCC 15 rejects it: C23, its default, removed ATOMIC_VAR_INIT (spscring.h), and the new -Wunterminated-string-initialization fires in print.c, which lely's -Werror makes fatal. Configure lely with -std=gnu17 and that warning not an error. jazzy, lyrical and rolling (0.3.4) build a newer lely that the shared patch covers. humble's own patch shadows the shared one, so the fix goes there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lled [skip ci] Turns the local checks of this PR into a recipe test, so later rebuilds keep them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports RoboStack/ros-jazzy#167 by @SammyRamone: adds
canopen(ros2_canopen withlely_core_libraries) to the shared selection on Linux (macOS/Windows not tried).lely_core_librariesinstalls the lely-core autotools build into the prefix from its own build directory. The PR's patch, refreshed for 0.3.4 (jazzy, lyrical, rolling) as a shared patch; humble's 0.2.13 keeps the original.c_stdlib_versionchange (and feat: add variant override vinca#114) isn't needed: the pinning is already glibc 2.28.Recipe test:
lely_core_librariesinstallsliblely-coappand thelely/coappheaders into the prefix, which the install step of the patch is about (shared/tests/ros2-lely-core-libraries.yaml).Built locally
lely_core_libraries,canopenand all canopen packages (core, interfaces, base/proxy/402 drivers, …); recipe tests not run (that build host needed--test skip, see Add Kinova Kortex and the Gen3 MoveIt configs (linux-64) #113).lely_core_libraries,canopenand all canopen packages, with their recipe tests.lely_core_libraries0.2.13 failed with GCC 15 (its older lely commit usesATOMIC_VAR_INIT, removed in C23, and trips the new-Wunterminated-string-initializationunder lely's-Werror); fixed in humble's patch, rebuild pending.Prepared and built on top of the current rosdistro syncs (#62 humble, #61 jazzy, #60 lyrical, #99 rolling) merged together, so it targets their package versions: merge after them. CI is held with
[skip ci]until the syncs are in.🤖 Generated with Claude Code