Repository navigation
feat(ledger): list_elements include_inactive, and the schedule surface from #1922 - #278
Merged
Merged
Conversation
`include_inactive` asks the elements read for retired accounts beside the active ones. Default unchanged. Needs robosystems #1923; the twin of typescript-client #294. Claude-Session: https://claude.ai/code/session_01VPxBBHkqhwkZ6Eq8EXSBR6
…#1922 Regenerated from #1922's OpenAPI (with main merged in): the `preview_schedule` operation, loan terms, schedule legs, the roll-forward rows, rebuild-schedule's editable fields and the envelope's definition; `monthly_amount` becomes optional on create. Generated tier only. Claude-Session: https://claude.ai/code/session_01VPxBBHkqhwkZ6Eq8EXSBR6
jfrench9
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_elements(graph_id, include_inactive=True)returns retired accounts beside the active ones, each withisActive, so roboledger-app's chart editor can list and reactivate them. Backend: robosystems #1923.Changes
From robosystems #1923 (GraphQL):
ListLedgerElements.graphqltakes$includeInactive: Boolean! = false;list_elementsgainsinclude_inactive. Default unchanged. Schema snapshot and codegen regenerated.From robosystems #1922 (OpenAPI, generated tier only): the
preview_scheduleoperation and its models:LoanTermsRequest,ScheduleLegRequest,PreviewScheduleRequest/Response,ScheduleRollForwardRow,ScheduleReplacementSummary; optional legs on the entry template,loan_termson the schedule metadata, rebuild-schedule's editable fields, warnings on the created response, the definition onScheduleMechanics;monthly_amountbecomes optional on create.Regenerated with OpenAPI from #1922's branch (with main merged in) and GraphQL from #1923's; the base URL is the usual
http://localhost:8000.Release
Additive: a client minor. It waits on the robosystems release that carries both #1922 and #1923; before it, the server rejects the new argument and has no
preview-schedule. roboledger-app passes it on the chart page after the bump. The twin of typescript-client #294.Testing
tests/test_ledger_client.py:list_elementssendsincludeInactivefalse by default. Ruff, basedpyright and the suite (726) pass; regenerated against the local API on #1923's branch.🤖 Generated with Claude Code
https://claude.ai/code/session_01VPxBBHkqhwkZ6Eq8EXSBR6