Repository navigation
feat(ledger): list_event_handlers, with approval state - #275
Merged
Merged
Conversation
The read the app's event-handler screen needs: every handler on the graph, highest priority first, with awaiting_approval for an AI client's suggestion that a person has not approved (robosystems #1918). The regen also drops the removed rollforward block arm's generated models (robosystems #1915); the information-block facades now type their bodies with the forecast arm in its place. Claude-Session: https://claude.ai/code/session_01VPxBBHkqhwkZ6Eq8EXSBR6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_event_handlers: the read roboledger-app's event-handler screen needs — every handler on the graph, highest priority first, withawaiting_approvalfor an AI client's suggestion that a person has not approved. Regenerated against the local stack on robosystemsfeature/event-handler-approval-gate(robosystems #1918); theeventHandlersfield waits on the robosystems release that carries it.Changes
clients/ledger_client.py):list_event_handlers(graph_id, event_type=None, is_active=None, awaiting_approval=None, limit=100, offset=0)→ the typed page.graphql/operations/ledger/ListLedgerEventHandlers.graphqland its ariadne-codegen models; the schema snapshot refreshed.EventHandlerResponsegainsawaiting_approval. The regen also removes the generated types of therollforwardInformation Block arm that robosystems #1915 removed (CreateRollforwardArm/UpdateRollforwardArm/DeleteRollforwardArm, their requests,AttributionFilter,LineItemMetadataPredicate,RollforwardMechanics) — dead surface: the arm never produced a fact, nothing in the apps or the integration template referenced them, and removal changes symbol resolution only. The information-block facades named the arm in their body type; they now name the forecast arm, which the server accepted all along.Compatibility
ADDITIVE for the facade (one new method); the information-block body types swap the dead rollforward arm for the forecast arm. Generated tier: the rollforward types above are removed, which rides this client minor per the SDK contract's dead-surface rule.
Testing
ruff check, ruff format --check, basedpyright, pytest (720 passed, 17 skipped).
just refresh-schema,just generate-graphqlandbin/generate-sdk.shran against the local stack serving the robosystems branch.🤖 Generated with Claude Code
https://claude.ai/code/session_01VPxBBHkqhwkZ6Eq8EXSBR6