Repository navigation
feat(ledger): list_report_shares — where a report went, with revocation state - #274
Merged
Merged
Conversation
…on state The sender's read behind share_report and revoke_report_share: each recipient graph, when, by whom, how many facts, and whether the share was revoked. report_id narrows to one report; omitted, the list is the graph's distribution log. Revoked rows stay out unless include_revoked is set. Schema snapshot refreshed for the reportShares field (robosystems #1913).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_report_shares: the sender's read of where a report went — each recipient graph, when, by whom, how many facts it received, and whether the share was revoked. It is the record behindshare_report/revoke_report_sharethat roboledger-app's revoke picker has had to guess from publish-list membership. Regenerated against the local stack on robosystemsbugfix/report-share-visibility(robosystems #1913); thereportSharesfield waits on the robosystems release that carries that PR — the next after v1.19.6. A server without it answers the query with a validation error, so nothing calls the new method until that deploy.Changes
clients/ledger_client.py):list_report_shares(graph_id, report_id=None, include_revoked=False, limit=100, offset=0)besiderevoke_report_share, returning the typed page (report_shares+pagination).report_idomitted is the graph's whole distribution log; revoked rows stay out unlessinclude_revokedis set, since a recipient shared to, revoked, and shared to again legitimately has one revoked row and one live. Sync path only, as the other GraphQL reads on this facade.graphql/operations/ledger/ListLedgerReportShares.graphql, and its ariadne-codegen models ingraphql/generated/list_ledger_report_shares.py(plus the generated registry files).graphql/schema.graphql: the only drift since v2.26.1 is the newreportSharesfield and its two types (ReportShareList,ReportShare).Compatibility
ADDITIVE — a new facade method and new generated models; nothing existing changed.
Testing
just test-allequivalent run in full: pytest (718 passed, 17 skipped), ruff check, ruff format --check, basedpyright — all clean.just refresh-schemaandjust generate-graphqlran against the local stack serving the robosystems branch.