Repository navigation
feat: held bank lines on the close, the as-closed label, and backfill on the worker - #273
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerated from the local stack on robosystems
mainat #1911 (2eb22014f), plus the facade for the new close blocker. A client minor: everything additive except one generated return type, below.Facade
heldBankLineCount/heldBankLineSample: bank lines a sync held out of an earlier, closed month, which block the next close (robosystems#1910).allowHeldBankLines/allow_held_bank_linesto close over them. Each line is recorded as decided and none posts; reopening the month gives them back instead.Generated tier (the sweep's server changes since the last regen)
ClosePeriodOperation.allow_held_bank_lines;FiscalCalendarResponse.held_bank_line_count/held_bank_line_sample.FactRecord.presentation/stamped_at,RenderingPeriodLite.presentation/stamped_at,LiveFinancialStatementResponse.presentation: the as-closed label (robosystems#1910).EvaluateRulesRequest.entity_id(robosystems#1903) andCreateTaxonomyBlockRequest.entity_id(robosystems#1907), owed since those PRs.backfillPlanHistorynow returns apendingenvelope (robosystems#1911).BackfillPlanHistoryResponse,BackfillPeriodOutcomeand the typed envelope leave the generated tier. No facade, app or the integration template uses them.Waits on the robosystems release that carries #1910 and #1911. Every consumer pins the client by lockfile, so nothing breaks before the bump.
Test plan
mainat #1911): the diff is empty in both clients.🤖 Generated with Claude Code