Skip to content

feat: held bank lines on the close, the as-closed label, and backfill on the worker - #273

Merged
jfrench9 merged 1 commit into
mainfrom
feature/held-bank-lines-and-as-closed
Oct 21, 2026
Merged

jfrench9 merged 1 commit into
mainfrom
feature/held-bank-lines-and-as-closed

Conversation

@jfrench9

@jfrench9 jfrench9 commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Summary

Regenerated from the local stack on robosystems main at #1911 (2eb22014f), plus the facade for the new close blocker. A client minor: everything additive except one generated return type, below.

Facade

  • The fiscal-calendar query reads heldBankLineCount / heldBankLineSample: bank lines a sync held out of an earlier, closed month, which block the next close (robosystems#1910).
  • The close-period facade takes allowHeldBankLines / allow_held_bank_lines to close over them. Each line is recorded as decided and none posts; reopening the month gives them back instead.
  • New tests: the override is sent, and the calendar fields are read.

Generated tier (the sweep's server changes since the last regen)

  • ClosePeriodOperation.allow_held_bank_lines; FiscalCalendarResponse.held_bank_line_count / held_bank_line_sample.
  • FactRecord.presentation / stamped_at, RenderingPeriodLite.presentation / stamped_at, LiveFinancialStatementResponse.presentation: the as-closed label (robosystems#1910).
  • EvaluateRulesRequest.entity_id (robosystems#1903) and CreateTaxonomyBlockRequest.entity_id (robosystems#1907), owed since those PRs.
  • backfillPlanHistory now returns a pending envelope (robosystems#1911). BackfillPlanHistoryResponse, BackfillPeriodOutcome and the typed envelope leave the generated tier. No facade, app or the integration template uses them.
  • Description and docstring drift from robosystems#1901, #1907 and #1908, with no shape changes.

Waits on the robosystems release that carries #1910 and #1911. Every consumer pins the client by lockfile, so nothing breaks before the bump.

Test plan

  • The full gate passes after the regen. The calendar fixtures gained the two fields the query now requires.
  • Regenerated a second time against the same stack (robosystems main at #1911): the diff is empty in both clients.

🤖 Generated with Claude Code

@jfrench9
jfrench9 merged commit 4574656 into main Oct 21, 2026
6 checks passed
@jfrench9
jfrench9 deleted the feature/held-bank-lines-and-as-closed branch October 21, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant