Repository navigation
feat: management dimensions — get_dimensions, create_dimension, update_dimension, sliced trial balance - #269
Merged
Merged
Conversation
…e_dimension, sliced trial balance Claude-Session: https://claude.ai/code/session_013UXnatpnbiixt1ZVHfdZAP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The management-dimensions surface from robosystems #1888, #1889 and #1890, regenerated, plus facades for it: the dimension catalog, a trial balance sliced by one member, and the department/class/location tags on journal and transaction lines. Waits on the robosystems release after v1.19.3, which carries those three PRs. Against v1.19.3 the new GraphQL fields (
trialBalance.sliced, linedimensions,dimensions) do not exist and the affected queries fail.Changes
api/,models/,graphql/generated/,graphql/schema.graphql), all from this effort's server changes; no unrelated drift:create_dimension/update_dimension, with their request, response and envelope typesStatementDimension/StatementDimensionResponseon the live statement request and responseJournalEntryLineDimensionsandline_dimensionsonUpdateJournalEntryRequestdimension_idson journal lines, events and schedule entry templatesledger/ListLedgerDimensions.graphqlGetLedgerTrialBalance.graphqltakes$dimensionType/$dimensionMemberIdand selectssliceddimensions { id dimensionType name }; the transaction lines also addflowQname, which the journal lines already hadLedgerClient):get_dimensions(graph_id, *, dimension_type=None, include_inactive=False)create_dimension/update_dimensionget_trial_balancegains keyword-onlydimension_type/dimension_member_idlive_financial_statementtakesdimensionin its body dict through the regenerated request modelCompatibility
ADDITIVE. New operations, optional request fields, new exports. The added query selections return new response fields; no existing field changed type or became narrower.
Testing
mainat the #1890 merge (just generate-sdk, which also refreshesschema.graphql), thenjust generate-graphql.just test-all: 712 tests passed, 17 skipped; ruff, format and basedpyright clean. Four new facade tests. Two existing mocks gained the fields their queries now select (sliced, linedimensions).Certification
🤖 Generated with Claude Code
https://claude.ai/code/session_013UXnatpnbiixt1ZVHfdZAP