Repository navigation
feat: create_journal_entry tags a consolidating entry - #265
Merged
Merged
Conversation
…d, adjusts_entity_id) An entry posted by hand in the group's consolidation entity names what it adjusts and the entity whose figures it adjusts, so the consolidation engine counts it toward what it already holds instead of proposing the elimination again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_journal_entrycan now tag a consolidating entry posted in a reporting group's consolidation entity. It names what the entry adjusts (adjustment_kind) and the entity whose figures it adjusts (adjusts_entity_id). The consolidation engine counts a tagged entry toward what the group already holds, so an elimination posted by hand is not proposed again. Without the tags, it could be proposed and posted twice. The API has accepted and validated both fields since consolidation C2; the facade had no way to send them.Changes
robosystems_client/clients/ledger_client.py):create_journal_entrytakes optionaladjustment_kindandadjusts_entity_idand carries them in thejournal_entry_recordedmetadata. They're sent only when set.Compatibility
ADDITIVE: two new optional keyword arguments, and nothing is sent unless they are passed. The server already accepts both fields in production.
Testing
just test-allpasses: 699 passed, 17 skipped; ruff, format, basedpyright clean.Companion PRs: RoboFinSystems/robosystems-typescript-client (the same option on
createJournalEntry), RoboFinSystems/roboledger-app (the journal entry modal on the consolidation entity).🤖 Generated with Claude Code