Repository navigation
Construct and peridocially send network config - #50
Merged
Merged
Conversation
guyfleeman
approved these changes
Nov 7, 2026
guyfleeman
left a comment
guyfleeman
left a comment
Contributor
There was a problem hiding this comment.
One thing we might want right now:
- This pulls camera.path but cameradriver.cpp pulls camera.device now.
I'm approving because I think most of my concerns are coming in the future but:
- This seems to be not reconstructed when the config file updates, so it can go stale. But we are dropping most of the config file in the future anyway.
- This doesn't announce anything until the first readImage() is done. This means it can block, inhibiting debug.
- Hostname as written is ambiguous if two instances are running on the same host
- We originally omitted some advanced configs from the packet, but the GUI supports them now and I've had to tweak a few in noisy environments like my home lab. Again, probably future work.
| } | ||
|
|
||
| /* Send config once per second. */ | ||
| if((realStartTime - lastConfigSendTime) > 1.0) { |
Contributor
There was a problem hiding this comment.
Probably Future Work: 1Hz is a bit slow for responsive UI. I think we previously discussed also sending once out of cycle when a update arrives.
Collaborator
Author
There was a problem hiding this comment.
That's adjustable for sure, I just wanted to start with a conservative value.
guyfleeman
added a commit
that referenced
this pull request
Nov 7, 2026
Collaborator
Author
|
This is just the baseline to be able to start porting over from Resources to config, during that I'll intend to implement dynamic config adjustments as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.