Repository navigation
Add Romanian postal code validator - #12
Merged
Robert-GeorgeDev merged 1 commit intoOct 27, 2026
Merged
Robert-GeorgeDev merged 1 commit into
Robert-GeorgeDev merged 1 commit into
Conversation
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
2 tasks done
Owner
|
Thanks @jay23606! Merged together with a small follow-up in #14 that ignores spaces in the input, like the other validators do. This will ship in the next release. Generated by Claude Code |
jay23606
deleted the
pr-go/11-add-a-validator-for-romanian-postal-code
branch
October 27, 2026 21:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
validatePostalCodeandisValidPostalCodefor the six-digit Romanian postal code format documented by Po?ta Rom�na. The validator returns a typed result and Romanian error message; county lookup is left optional as stated in the issue.Tested with
npx vitest run test/postal-code.test.tsandnpm run typecheck.Regression test: fails on base twice (/Cannot find module '../src/postal-code.js'/), passes on fix twice (
npx vitest run test/postal-code.test.ts)Fixes #11