Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
pkaminski
commented
Oct 26, 2026
pkaminski
left a comment
pkaminski
left a comment
Member
Author
There was a problem hiding this comment.
@pkaminski reviewed 9 files and all commit messages.
Reviewable status: 0 of 9 files reviewed, all discussions resolved (waiting on earlAchromatic).
pkaminski
force-pushed
the
codex/fix-tribute-editability
branch
from
October 27, 2026 00:43
bf6b17a to
5bb91ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attaching Tribute to a plain div or to
contenteditable="false"currently succeeds becausecontentEditablecontains a truthy string. CheckisContentEditableinstead so the existing error guard uses effective editability, including inheritance. Inputs and textareas remain accepted.Add six browser regression cases covering plain and explicitly disabled divs, explicit and inherited editability, inputs, and textareas. Update the README examples, rebuild all distributed bundles, and bump the publishable library from 5.1.3 to 5.1.4.
Validation: the two rejection tests failed against the original bundles while the other 36 passed. After the fix and Rollup rebuild, all 38 tests pass in headless Chrome.
git diff --checkpasses.Follow-up to the migration review. Stacked above security PR #18 and Yarn migration #19; merge from the bottom of the stack.
Linux CI also passes: immutable install, build, and all 38 browser tests. This PR is now part of native stack #20; Jacob (
@earlAchromatic) is requested for review.This change is