Skip to content

Reuse the shared build output check - #25

Open
pkaminski wants to merge 1 commit into
masterfrom
codex/appengine-shared-build-check
Open

pkaminski wants to merge 1 commit into
masterfrom
codex/appengine-shared-build-check

Conversation

@pkaminski

@pkaminski pkaminski commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Replace the duplicated build check with Reviewable/actions/.github/workflows/check-build-output.yaml@master, using read-only contents permission. It preserves push and pull-request triggers, Node 24, and Yarn, and verifies committed output under dist/, including newly generated untracked files. The old submodule checkout is unnecessary because no gitlink is tracked and the SDK is installed from npm.

The status-check name changes from check-build to check-build / check-build, matching the other repositories using the shared workflow.

Validation: both the push run and pull-request run passed dependency installation, the build, and the output check.


This change is Reviewable

@pkaminski
pkaminski marked this pull request as ready for review October 21, 2026 22:05

@pkaminski pkaminski left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkaminski reviewed 1 file and all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T22:07:20.614708Z 08cbd4f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pkaminski
pkaminski requested a review from snoack October 21, 2026 22:08

@pkaminski pkaminski left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+r:@snoack

@pkaminski made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on snoack).

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@snoack snoack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@snoack reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pkaminski).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants