Repository navigation
Fix SNES return boundaries, mod paths and diagnostic formatting - #282
Merged
Merged
Conversation
ppu.c calls the SnesHdFrame* helpers from hd_jobs.c, and the other PPU harnesses in run_c_tests.sh already link it. Fixes #263.
The atomic-output test captured the v2_regen child with text=True. On Windows the child writes its stdio in cp1252 unless UTF-8 mode is on, and a parent started with -X utf8 decodes the pipes as UTF-8, so the em dash in the stub-lint banner raised UnicodeDecodeError in the reader thread and the diagnostic was lost. Run the child in UTF-8 mode and decode as UTF-8, and check that the diagnostic arrives. Fixes #270.
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix six correctness and portability failures:
Includes the contributor commits from #268 and #275, with expanded return-boundary and diagnostic regressions. Also includes #274: the Linux view-anchor test must link hd_jobs.c; this repairs the pre-existing CI linker failure without changing runtime source.
Validation: reported negative controls reproduced; the 41-test diagnostic and 85-test return suites pass. Windows/Linux PPU and mod catalog/state/plugin tests pass. Matched regenerated native game builds pass a 3,600-frame scripted race and current-build memory/file save-load checks; captured audio, final frame and game RAM match exactly. Matched runtime samples are neutral within observed variation. Network was disabled equally in these consumer checks.
Scope: preserving the latch does not remove pre-existing mapped-I/O effects during metadata reads. Windows path tests cover local long/Unicode/relative/extended paths and unit-test UNC conversion.
Fixes #264. Fixes #266. Fixes #267. Fixes #270. Fixes #271. Fixes #273.
Fixes #263.