Repository navigation
feat(gate): per-gate needs - #5
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs = [..]per gate: a gate starts after the gates it names pass; a failed, timed-out or skipped need skips it (SKIP ... needs ), the failing gate's exit stays the verdict; unknown names and cycles (including through serial chains) refuse the file (exit 129); a need outside the current run is ignored, sogate run lintstill works alone. Shown in --list and --json.Why: go-* repos start lint, fmt, vuln and lint-windows together, and on a cold build cache each
go toolbuilds the same binaries at once. Measured on go-safefs, fullgate -q, GOCACHE wiped per cold run, 6 runs each: cold median 27.6s today vs 15.5s with atoolsgate andneeds = ["tools"](-44%); warm 0.99s vs 1.10s. Tests run real shell gates through Run: ordering, failed-need skip, unknown name, cycle, absent need.