Repository navigation
Mark tag group messages as the tag groups' - #1678
Merged
Merged
Conversation
Players write the join and leave messages, so one with a map ping in it passed for a server message. Every tag group notice now starts with [Tags], in the colour of the Tags button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lex
marked this pull request as draft
November 4, 2026 21:49
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lex
marked this pull request as ready for review
November 4, 2026 21:53
grilledham
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tag group's join and leave messages are written by players and were printed as they are, with no name in front, so they read like the server's. A join message such as "The fish have on their way to [gps=-0.7,0.2,nauvis] attack imminent" passed for a real server warning.
Every tag group notice now starts with [Tags], in blue, as other features mark theirs ([Corpse], [Auto stash]): joining, leaving, and a group being created, edited or deleted.
tag_group.message_prefix, in every language, using the word each one's Tags tooltip already uses.Tests
luacheck .: 0 warnings / 0 errors.Screenshots
Top: develop. Bottom: this PR. Drawn as labels where the chat shows, since game screenshots leave the chat out; in chat the map ping also shows its location.
🤖 Generated with Claude Code