[lex]

Every dialog gets the same layout, like Factorio's own: its content in an inner frame, and one row of buttons along the bottom, all the same height, with space between them to drag the window by. Following the rule from #1668's review, no dialog has a Close or Cancel button: its X closes it.

Change

• utils/gui.lua:
  • Gui.add_dialog(player, spec): a window (Gui.add_window) with its content in a padded inner frame (inside_shallow_frame_with_padding). Returns the window, the content and the X.
  • Gui.add_dialog_buttons(frame, left, right): the row of buttons under it. left holds the likes of Clear and Reset, right the likes of Delete and then the confirming button. Without a style of their own, the last one on the right is a confirm_button and the rest dialog_buttons, so they all line up. A drag space between the two sides is never narrower than 24, so every dialog has somewhere to drag it by.
  • Docked side panels keep their width when they don't all fit beside each other, instead of being squashed into scroll bars.
• Dialogs with buttons (screenshots 1 to 6):
  • the poll editor: Clear on the left, Delete (when editing) and Create poll on the right;
  • the task editor: Clear, then Create task;
  • the announcements editor: Clear and Reset, then Confirm;
  • the tag editor: Delete (when editing), then Create;
  • the report form: Submit; Cancel goes;
  • popups: OK, now the confirming button.
• Dialogs whose only button was Close keep only their X, with their content in the inner frame (screenshots 7 to 12): the reports list, Configure Restart, Radio, Rich Text, the description generator and the paint palette.
• Rich Text's eleven image types sit in a 4 by 3 grid, with the picker, a slot_button_in_shallow_frame, in the twelfth place, and the text box below as wide as the grid (screenshot 10).
• Styles go through Gui.set_style in the code this touches.

Tests

• The utils/Gui tests with a player, in a 2.1.24 client: 28 passed, 0 failed.
• Every dialog above, on Move Polls and Tasks to side panels, and their editors to windows #1668 and on this branch, in a 2.1.24 client.
• pwsh .github/scripts/run-all.ps1 <factorio> crashsite danger-ore diggy frontier: all pass. luacheck .: 0 warnings / 0 errors.

Screenshots

🤖 Generated with Claude Code

[RedRafe]

This probably doesn't matter since it's never used, but for Rich Text I'd put the 11 fields into a 3x4 | 4x3 | 6x2 table with sprite button in the 12th spot so it's more appealing. For the button style, I'd use the lot button in shallow frame one

Other than that, everything looks clean

[lex]

Thanks! Done in 1193f4b: the eleven image types are a 4 by 3 grid with the picker in the twelfth place, as a slot_button_in_shallow_frame, and the text box under them is as wide as the grid (screenshot 10).

And from your review of #1670, ea2d63c takes the announcements back to their own text box, so they stand out; that change was in this PR, not #1670.