Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1052 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 141 141
Lines 9011 9011
=======================================
Hits 8790 8790
Misses 221 221 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Cover the VecSim training gaps identified in the final review of #1029:
The related default-size training and L2 mutation-score integration tests are in RediSearch #11330.
Which issues this PR fixes
MOD-14958 test coverage follow-up. Based on
mainafter #1050 merged.Main objects this PR modified
tests/unit/test_hnsw_tiered.cpp: threshold boundaries and the typed concurrency matrix.tests/unit/test_hnsw_sq8.cpp: remove the original single-configuration concurrency test now covered by the matrix.Validation
Debug build on dorer-intel with SVS enabled; formatting and independent review passed.
ROOTenvironment variable set.Mark if applicable
Note
Low Risk
Test-only changes with no production code, API, or serialization impact.
Overview
Strengthens tiered SQ8 unit coverage by moving concurrency testing into the typed tiered suite and adding quantization training threshold boundary checks.
test_hnsw_tiered.cppaddsTrainingThresholdIsCapped, which asserts the effective normalization/training set size ismin(requested, MAX_QUANT_NORMALIZATION_SET_SIZE)for L2, IP, and cosine. It replaces the old single-scenario test withConcurrentQueriesDuringNormalizationTransition, a typed matrix over float32/float16, single/multi-label, L2/IP/cosine, and async vs in-place writes. That test pauses at before/after quantization finalization and first backend insert before flat removal, runs concurrent TopK, range, and batch queries (plus index introspection APIs), and asserts OK replies with unique labels and finite scores through all three transition phases.test_hnsw_sq8.cppdrops the duplicateConcurrentQueriesDuringNormalizationTransitiontest that only covered one float32 L2 configuration.Reviewed by Cursor Bugbot for commit cabcf46. Bugbot is set up for automated code reviews on this repo. Configure here.