Repository navigation
fix(q): reject empty frames with unknown message types - #18
Merged
protocolstardust merged 4 commits intoOct 12, 2026
Merged
protocolstardust merged 4 commits into
protocolstardust merged 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User-facing behavior
Malformed Q clients that send an unknown message type now get the connection closed consistently, even when the frame has no body. Valid async, sync, and response frames keep the existing behavior.
Testing
git diff --checkmake recheckNotes
This branch is stacked on top of the current open fix branches, because the upstream repository cannot target fork-only base branches. Until those PRs land, this PR shows the earlier stacked commits too.