Repository navigation
fix(q): distinguish decode failures from Q errors - #16
Closed
belowzeroff wants to merge 2 commits into
Closed
belowzeroff wants to merge 2 commits into
belowzeroff wants to merge 2 commits into
Conversation
Collaborator
|
Closing as superseded: #15 and #17–#21 landed on master via #21 (and #14 via its own merge), and #17 deliberately reverted the one change this PR still carries over master — returning NULL for a malformed decode instead of the core's error object. master keeps the #17 behaviour, so there is nothing left here to merge. Thanks for the series. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RAY_ERRORfor valid Q error frames fromq_decodeTesting
git diff --checkNotes
This branch is stacked on top of
fix/q-codec-transport-safety/ #15, because GitHub does not allow targeting a fork-only base branch in the upstream repository. Until #15 lands, this PR shows both commits.