Skip to content

chore: add security scanning workflows - #3968

Open
haribabug wants to merge 4 commits into
develop_deprecatedfrom
add-security-scanning
Open

haribabug wants to merge 4 commits into
develop_deprecatedfrom
add-security-scanning

Conversation

@haribabug

Copy link
Copy Markdown

Security Scanning Workflows Enablement

This PR adds standardized security scanning workflows and configurations from ROCm/rocm-repo-template.

Security Controls

  • PR Security Scan
  • Weekly Security Scan
  • Dependabot
  • CodeQL, Bandit, Gitleaks, Trivy, and Zizmor

Files added / updated

  • .github/workflows/pr-security-scan.yml — scans every pull request
  • .github/workflows/weekly-security-scan.yml — scheduled weekly scan
  • .github/dependabot.yml — automated dependency updates
  • .github/scan_tools_configs/bandit.yml — Python static analysis config
  • .github/scan_tools_configs/gitleaks.toml — secret detection config
  • .github/scan_tools_configs/trivy.yml — container/dependency vulnerability config
  • .github/scan_tools_configs/zizmor.yml — GitHub Actions security config

Why

This change aligns this repository with the ROCm GitHub Organization Security Baseline and enables consistent security controls across ROCm repositories.


For more details, refer ROCm GitHub Org Security Controls Baseline Architecture

Support/Questions: Teams Channel ROCm Security Discussions

Copies standardised security scanning config from
ROCm/rocm-repo-template.
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Syncs .github/dependabot.yml with the latest version from
ROCm/rocm-repo-template.
Syncs 6 security scanning file(s) with the latest version from
ROCm/rocm-repo-template.
@github-actions

Copy link
Copy Markdown

Caution

1 potential secret finding(s) were committed in this pull request. Treat each credential as compromised and revoke or rotate it now, even if a later commit removed it. Deleting the line or force-pushing does not undo the leak: the commits stay reachable from this pull request and from every clone or fork, and automated scanners harvest secrets pushed to public repositories within minutes.

If a finding is a test fixture or a false positive, allowlist it in the configuration of the scanner that reported it.

Security scan found 1 critical or high finding(s) on lines changed by this pull request (coverage incomplete)
Scanner Severity Rule Location Finding
Gitleaks HIGH generic-api-key src/kernels/gfx90a.tn.model:1 Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

Coverage was incomplete:

  • Security scan / Security scanners concluded with failure.

View the security scan run for complete reports.

“New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta.

Updates 8 security scanning file(s) to the latest version from
ROCm/rocm-repo-template.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants