Repository navigation
fix: preserve Weave checks and remote artifact recovery - #263
Merged
Merged
Conversation
Base automatically changed from
codex/fix-audit-candidate-budget-20261025
to
main
October 26, 2026 17:28
A static printer or shell wrapper could satisfy expected_output without the real check. A trailing comment swallowed the pytest pass report. Anthropic rejected persisted developer instructions. A missing Docker or VM artifact failed an otherwise successful child.
Here-strings, awk, sed, jq, and interpreter one-liners could still satisfy expected_output. A scheduler lease can also shrink a soft cap below the armed commit reserve and make snapshot_session raise.
A python -c script could mention open( or glue the script onto -c and still print the expected text. Shrinking the commit reserve to a quarter of the new cap also let a snapshot spend tokens the source already had to commit.
python -ic, python -bc, node -p, perl -E, and uv run python -c could still print the expected text and pass a Weave probe.
KaiEureka
force-pushed
the
codex/fix-pr257-false-verification
branch
from
October 26, 2026 17:32
ab409d7 to
d38251d
Compare
KaiEureka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep Weave verification compatible with executable script checks while distinguishing static output from observed test results. Interpreter options end at the script or module entry, literal shell script paths with standard execution options remain usable, and passing per-target pytest records remain valid when expected text also appears in a target name. Shared comment parsing places pass reporting before trailing comments and preserves quoted or escaped hash characters in arguments.
Preserve optional remote artifacts without hiding transport errors. A missing Docker or VM artifact is skipped only after a complete successful absence probe. A Docker daemon error, timeout or incomplete probe retains the original transfer failure and the child artifacts for recovery.
Integrate main after #257 using its existing snapshot budget and Anthropic history implementations. The four original commits retain their human author, with generated coauthor trailers removed.
Validation passed locally on Python 3.12 and 3.14. Root checks passed 119 session/provider cases, 136 command cases, 22 shell-option cases and 9 artifact recovery cases. Independent checks passed 335 command cases, with 4 PHP/Lua execution cases skipped because those interpreters are unavailable locally, and 196 artifact/session/VM cases. Real local scripts and pytest runs cover passing and failing outcomes; remote transport lifecycle tests use local substitutes. A final independent review passed 316 cases with the same 4 capability skips. Whole-repository Ruff, import rules and dependency checks pass. Complete CI passed on
c691e1e4. Python 3.10 through 3.14, distribution artifacts, macOS platform integrity and browser/SQLite fixtures all passed.