Repository navigation
Make gaugefixing for svd_full and eigh GPU friendly - #307
Merged
Merged
Conversation
Jutho
reviewed
Oct 13, 2026
Jutho
approved these changes
Oct 13, 2026
Jutho
left a comment
Jutho
left a comment
Member
There was a problem hiding this comment.
Aside from the one suggestions, approved!
(which I guess makes the suggestion a mandatory change 😄 )
lkdvos
reviewed
Oct 13, 2026
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
Add a comment reminding us to investigate further sign related optimizations
lkdvos
approved these changes
Oct 13, 2026
lkdvos
reviewed
Oct 13, 2026
Jutho
approved these changes
Oct 13, 2026
kshyatt
enabled auto-merge (squash)
October 13, 2026 15:12
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd previously fixed this for
svd_compactand now it's extended tosvd_fullandeigh_*. The new implementations avoid some forced device synchronization and a lot of smaller kernel launches in favour of fewer, bigger broadcast ops.