Repository navigation
feat(api): sql-workbench routes as spec'd UI API extension endpoints (#20) - #21
Merged
Merged
Conversation
…endpoints Replace SqlWorkbenchRouteProvider (21 raw /qqq/v1/sql-workbench Javalin routes) with one MiddlewareSpecExtension "sql-workbench" (prefix /sql-workbench). JSON operations use AbstractJsonEndpointSpec; the result export stream extends AbstractEndpointSpec. Paths, methods and payloads are unchanged, and so are the permission checks, read-only gates, limits and audit. The generated fragment is committed at openapi/qqq-v1/sql-workbench.yaml and checked by a contract test. The server tests run in strict raw-route mode. The core baseline becomes 4.1.0-RC.6, the first RC with the extension point (QRun-IO/qqq#1128). Closes #20 (architecture review QRun-IO/qqq#1150, finding F2). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Enforce the qbit-bom#10 guardrails (G1, G3, G4, G7) and run tests in strict raw-route mode (G2). All pass on the released QQQ 4.1.0-RC.6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
KofTwentyTwo
marked this pull request as ready for review
October 14, 2026 12:15
Member
Author
|
QQQ 4.1.0-RC.6 is released. Verified locally against it with |
KofTwentyTwo
added a commit
that referenced
this pull request
Oct 14, 2026
…guardrails) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #20 (architecture review QRun-IO/qqq#1150, finding F2). sql-workbench was the largest blocker for the strict raw-route flip (G2, QRun-IO/qqq#1159).
SqlWorkbenchRouteProviderand its 21 raw/qqq/v1/sql-workbench/*routes.MiddlewareSpecExtensionnamedsql-workbench, with the established prefix/sql-workbench(so the full paths are unchanged), and 21 endpoint specs. JSON operations extendAbstractJsonEndpointSpec; the export stream extendsAbstractEndpointSpec.src/main/resources/openapi/qqq-v1/sql-workbench.yaml, checked bySqlWorkbenchApiContractTest(the qbit-collaboration#8 pattern).withStrictUiApiRoutes(true).docs/UI-API.md, README, CHANGELOG./qqq/v1/sql-workbench)/capabilitiessqlWorkbenchGetCapabilities/schema/{backendName}sqlWorkbenchGetSchema/executesqlWorkbenchExecute/explainsqlWorkbenchExplain/executions/{uuid}/rowssqlWorkbenchGetRows/executions/{uuid}/exportsqlWorkbenchExportResult/executions/{uuid}/cancelsqlWorkbenchCancelExecution/historysqlWorkbenchGetHistory/notebookssqlWorkbenchListNotebooks,sqlWorkbenchCreateNotebook/notebooks/{id}sqlWorkbenchGetNotebook,...UpdateNotebook,...DeleteNotebook/notebooks/{id}/publish,/duplicatesqlWorkbenchPublishNotebook,sqlWorkbenchDuplicateNotebook/notebooks/{id}/versions,/versions/{n}sqlWorkbenchListVersions,sqlWorkbenchGetVersion/notebooks/{id}/versions/{n}/restoresqlWorkbenchRestoreVersion/notebooks/{id}/snapshotssqlWorkbenchListSnapshots,sqlWorkbenchCreateSnapshot/notebooks/{id}/snapshots/{snapshotId}sqlWorkbenchDeleteSnapshotWire changes: none. Next keeps working unchanged. Next can then vendor
sql-workbench.yamland drop these 21 calls from its off-spec list.Draft until QQQ 4.1.0-RC.6 is released
The pom targets RC.6, which has the extension point (#1128). It was verified locally against core develop as
-Dqqq.snapshot.version=4.1.0-ARCHRC6-SNAPSHOT:mvn verify: 133 unit tests and 8 Postgres integration tests, 0 failures;CI goes green once RC.6 is on Central.
🤖 Generated with Claude Code