tiny fix for windows: write PET log file as UTF-8 - #164
Merged
Merged
Conversation
FileHandler used the OS default encoding, which on Windows is a legacy codepage (cp1252) that cannot encode the box-drawing characters in the timestamps and tables. Every record raised UnicodeEncodeError inside the handler, so the log file was left empty while the run carried on. No effect on Linux, where UTF-8 is already the default. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
KriFos1
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileHandler used the OS default encoding, which on Windows is a legacy codepage (cp1252) that cannot encode the box-drawing characters in the timestamps and tables. Every record raised UnicodeEncodeError inside the handler, so the log file was left empty while the run carried on.
No effect on Linux, where UTF-8 is already the default.