Byonoy A96A: the reader carries the name it is given - #1301
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ByonoyAbsorbance96is the base unit it inherits, but names itselfname + "_base", andbyonoy_a96ahands itname + "_reader"on top. Sobyonoy_a96a("a96a")returns a resource calleda96a_reader_base, whose holders area96a_reader_base_plate_holderanda96a_reader_base_illumination_unit_holder.ByonoyAbsorbance96takes the name it is given.byonoy_a96agives the reader the name it is called with; the illumination unit keepsname + "_illumination_unit".Any deck saved with the old names loads under them; a script that looks a reader up by name finds it under the name it passed.
🤖 Generated with Claude Code