Byonoy A96A: the illumination unit is not put down on a plate it would hit - #1300
Merged
Merged
Conversation
…d hit Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The illumination unit sits on top of / is being moved onto parking_/detection_unit.
There might a plate on the parking_/detection_unit's plate_holder.
But the illumination unit only has limited space underneath it.
Nothing checks that the plate fits under it, so a plate too tall is hit as the unit comes down.
The plate holder already refuses the other order - a plate dropped while the unit is on the base.
_ByonoyAbsorbanceIlluminationUnitHolderrefuses a drop when what stands on the plate holder reaches aboveMAX_PLATE_SIZE_Z, 16.0 mm. The parking unit and the detection unit both get it, throughByonoyAbsorbanceBaseUnit.get_highest_known_point()over the plate holder, so a lid, or anything else on the plate, counts.Like the plate holder's interlock, it only fires where a move checks the destination before moving.
Tests: 16.0 mm goes on and 16.01 mm does not; a 14 mm plate under a 4 mm lid that nests 1 mm stands 17 mm and is refused.
🤖 Generated with Claude Code