Repository navigation
Conversation
uslsteen
requested changes
Oct 20, 2026
uslsteen
left a comment
uslsteen
left a comment
Contributor
There was a problem hiding this comment.
As far as I understand, firstly, PR #22 introduces syntactic constructs and assembly support. However, PR #22 contains far more changes than are strictly necessary for that purpose. I understand this might be too complicated, but I would like to see the independent changes related to modifying the architecture structure separated into different pull requests.
| return Statement(shape, outputs, outputs_types, kind, specifier, inputs) | ||
|
|
||
| def serialize_statement_seq(seq: StatementSeq) -> str: | ||
| return ''.join(f'{serialize_statement(s)};\n' for s in seq.stmts) |
Contributor
There was a problem hiding this comment.
Do we really need these changes in this particular pull request?
Collaborator
Author
There was a problem hiding this comment.
No, the third commit is mostly orthogonal.
The intention behind doing it in one go was to minimize breaking PRs. I can split it
belovdv
force-pushed
the
modify_arch_structure
branch
from
October 20, 2026 14:23
0e42cf5 to
7242052
Compare
belovdv
marked this pull request as draft
October 20, 2026 18:25
belovdv
marked this pull request as ready for review
October 20, 2026 18:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements part of #21