Repository navigation
feat(asap-tools): render sketch-bench e2e queries as ClickHouse SQL #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9d6727f
feat(experiments): fake_exporter-equivalent dataset for ClickHouse ge…
milindsrivastava1997 dfa8022
feat(experiments): translate generated2 PromQL workloads to ClickHous…
milindsrivastava1997 f2a24f4
feat(asap-tools): translate sketch-bench e2e PromQL to ClickHouse SQL…
zzylol 7107a85
fix(asap-tools): use Prometheus 2.53's closed windows in sketch-bench…
zzylol 392ecf5
feat(asap-tools): multi-grouping sketch-bench queries in ClickHouse SQL
zzylol 28cc841
feat(asap-tools): ASAPQuery's left-open window for multigroup queries
zzylol 24310d6
feat(asap-tools): request aligned eval times in sketch-bench ClickHou…
zzylol c5d98e3
fix(asap-tools): compare ts with DateTime64 bounds in sketch-bench ra…
zzylol c0be5c5
Merge origin/main into feat/e2e-sql-from-table
zzylol f8a50b5
feat(asap-tools): take ASAPQuery SQL from the table's structured entries
zzylol 6418827
fix(asap-tools): address #844 review on sketch-bench SQL rendering
milindsrivastava1997 18b9091
fix(asap-tools): validate sketch-bench table inputs at generation time
milindsrivastava1997 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two contradictory "Prometheus 2.53" window conventions now coexist. This file uses left-open
ts > END - window;sketch_bench_workloads.pyuses closed[T-d, T]for the same Prometheus version. With 1s whole-second scrapes a[1m]query reads 60 samples here vs 61 there, so sum/count/quantile and rate extrapolation (first_t/to_start) diverge. Suggest one shared window helper. (Anchored here; theselect()at line ~60 has the same predicate.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prometheus 2.x range selectors are closed,
[T−d, T]; left-open arrived in 3.0. So this PR is correct and generated2 is off by one sample. Changing generated2 (merged in #837) changes its results, so it gets its own PR rather than going into this one: #867. generated2'stsisDateTime, so the fix there is just>→>=.