Repository navigation
refactor(planner): delete the greedy optimizer - #807
Merged
Merged
Conversation
The rqe-optimizer MILP replaces it. Removes candidate_gen, cost_model, greedy, sketch_properties, constants, translator, label_set_facts, pipeline, the profile-selecting cost loader and candidate-gen-dump. Hint extraction moves into milp.rs, and asap-optimizer-cli is MILP-only (--milp and the greedy flags are gone). Refs #790 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #790 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 of 9 tasks
# Conflicts: # asap-planner-rs/src/bin/optimizer_cli.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A4 of #790. The rqe-optimizer MILP replaces the greedy optimizer, so this deletes it instead of commenting it out, which the issue originally planned. Git history keeps the old code.
Changes
candidate_gen,cost_model,greedy,sketch_properties,constants,translator,label_set_facts,pipeline, and thecandidate-gen-dumpbinary (with itsCargo.tomland Dockerfile entries).atomic_costs.rs: onlyload_flat_atomic_cost_tableand theAtomicCostEntry/AtomicCostTablere-export remain. The profile-selecting loader andresolve_atomic_costsare gone.solution.rs: onlyOptimizerItem.error.rs: only the two errorsaqe_extractorreturns.aqe_extractor::gcdis removed (onlycandidate_genused it).extract_hinted_itemsandconfig_to_rqesfrompipeline.rsintomilp.rs.MissingMetricHintsandMetricsWithoutHintsare nowMilpErrorvariants.asap-optimizer-cliis MILP-only: the--milp,--label-set-factsand--atomic-cost-workloadflags are removed, and--workload-factsand--atomic-costsare plain required arguments. Nothing in the repo passed--milp..design_docs/. The.mddesign docs are unchanged.Interface change
asap_planner::optimizerno longer exports anything greedy-related (run_greedy_pipeline,LabelSetFacts, the cost-model types). The only callers were the two binaries in this crate.Test plan
pipeline.rstomilp.rs: metric hints required, unhinted metric rejected, spatial-only range, and group flattening.cargo test -p asap_planner, clippy with-D warnings, fmt; pre-commit hooks passed.asap-optimizer-cli --helpshows the MILP-only flags.Next: A5′ (
asap-planner --planner legacy|milp), stacked on this PR.🤖 Generated with Claude Code