Repository navigation
fix(planner): bump rqe-optimizer to S8 and split Sum/Count/TopK capabilities - #801
Merged
Merged
Conversation
…ilities sketch-bench split SumOrCount into Sum and Count and TopK into TopKByValue and TopKByCount, so the two halves of an avg rewrite, and value- vs count-ranked top-k, no longer share one deployment. A topk with unknown weighting is now an error. solve_milp returns S8's MilpSolution (active deployments with retained count, per-Raqe deployment and merged count); the CLI prints both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- The unservable pre-check calls rqe_optimizer::enumerate::unservable instead of re-implementing it, and checks one Raqe per item, since an item's occurrences are identical. - TopkWeightingUnknown no longer implies a bare topk is invalid. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #790 (session 3a). This is the step before A3: it moves the planner to sketch-bench S8 and to the new capability split.
What
Cargo.lock:rqe-optimizeris now at sketch-bench3b31dfb. That includes feat(rqe-optimizer): family properties, shared fixed-size sketches and DeltaSet key tracker sketch-bench#160 (S4b family properties and key tracker), 157 update docs to point to projectasaparroyo fork #163 (Sum/Count and TopK split,deny_unknown_fields) and Added quotes to asap-sketch-ingest quote to preserve case #168 (S8 plan output).Capability mapping (
optimizer/milp.rs):SumCounttopk_count_events = false(topk(k, sum_over_time(...)))TopKByValuetopk_count_events = true(topk(k, count_over_time(...)))TopKByCountMilpError::TopkWeightingUnknownThe other statistics map as before.
solve_milpnow returns only S8'sMilpSolution: active deployments withretained_instance_count, and for each Raqe its deployment index andmerged_instance_count. It no longer returns the candidate list andmapping.asap-optimizer-cli --milpalso prints each deployment's retained count and key-tracker flag, and each Raqe'sn.Interface for A3 / 4a
MilpSolution.deployments[i].deploymentand.retained_instance_count, andMilpSolution.raqes[j].deploymentand.merged_instance_count.raqes[j]lines up withMilpWorkload.raqes[j].Test plan
cargo test -p asap_planner, clippy with-D warnings, fmt; pre-commit ran workspace check, clippy and test.sketch-bench/out_10_6_26_1342/rqe_atomic_costs.json, scrape interval 15s:nprint, e.g.max_over_time[1h]→ x=240s, y=60s, retained=61, n=15.🤖 Generated with Claude Code