Repository navigation
feat(planner): accept optional measured_at on atomic-cost entries - #796
Merged
Merged
Conversation
sketch-bench#155 (for sketch-bench#147) adds a measured_at block to every atomic-cost row. AtomicCostEntry denies unknown fields, so a regenerated table would fail to load. Carry it as an optional opaque Value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
milindsrivastava1997
changed the title
milindsrivastava1997
approved these changes
Oct 6, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProjectASAP/sketch-bench#155 (part of sketch-bench#147) adds a
measured_atblock to every rowapproxbench atomic-costswrites: items, keys and value range per instance, the merge operand size, and the value distribution.AtomicCostEntryhere hasdeny_unknown_fields, so a table regenerated after that PR would fail to load. This addsmeasured_at: Option<serde_json::Value>,#[serde(default)]and omitted when absent. It is carried opaquely, like a synthetic workload description, since the planner doesn't use it yet.Merge before regenerating the atomic-cost table with a sketch-bench that includes #155.
Test plan
measured_atloads, one without still loads, any other unknown field is still refusedcargo test -p asap_planner --lib(136 passed),cargo clippy -p asap_planner --lib --tests -- -D warnings🤖 Generated with Claude Code