Skip to content

feat(planner): depend on sketch-bench rqe-optimizer MILP - #794

Merged
milindsrivastava1997 merged 1 commit into
mainfrom
790-a1-rqe-optimizer-dep
Oct 5, 2026
Merged

milindsrivastava1997 merged 1 commit into
mainfrom
790-a1-rqe-optimizer-dep

Conversation

@milindsrivastava1997

Copy link
Copy Markdown
Contributor

Summary

A1 of #790.

  • asap-planner-rs depends on rqe-optimizer from ProjectASAP/sketch-bench main (lock pins 964ccb58). Pin to an explicit rev after S8.
  • Smoke test asap-planner-rs/tests/rqe_optimizer_smoke.rs solves a one-query minimize_cost MILP through HiGHS.
  • HiGHS build deps (cmake, libclang-dev) added to:
    • asap-planner-rs/Dockerfile (plus libstdc++6 at runtime, needed once the planner calls the solver)
    • asap-query-engine/Dockerfile: the engine depends on asap_planner, so it compiles HiGHS too
    • rust.yml (both jobs) and the compare_patterns job in correctness.yml (also pulls in the planner)

Interface for later sessions

  • Crate path: rqe_optimizer::{milp::minimize_cost, objectives::MachineFamily, Rqe, Deployment, ...} at sketch-bench main. For local development against a sketch-bench checkout, add a [patch."https://github.com/ProjectASAP/sketch-bench"] with rqe-optimizer = { path = "../sketch-bench/rqe-optimizer" } in the workspace Cargo.toml (don't commit it).
  • The smoke test uses the current main API; it will need updating when S1/S8 change Rqe / Deployment.

Verification

  • cargo clippy --workspace --all-targets --all-features --locked -- -D warnings
  • cargo test -p asap_planner
  • docker build -f asap-planner-rs/Dockerfile . and docker build -f asap-query-engine/Dockerfile . both succeed; both binaries run in their runtime images.

🤖 Generated with Claude Code

Add rqe-optimizer (sketch-bench main) as a git dependency of asap-planner-rs
with a smoke test that solves a one-query MILP through HiGHS. Install cmake
and libclang-dev for the HiGHS build in the planner and query-engine images
and in the CI jobs that compile the planner.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@milindsrivastava1997
milindsrivastava1997 merged commit 55cc16d into main Oct 5, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant