Repository navigation
feat(planner): millisecond precision for SQL/Elastic data_ingestion_interval #427
Description
Activity
PR #437 also surfaces a related boundary:
SQLPatternMatcher::newin the vendoredsql_utilitiescrate (asap-common/dependencies/rs/sql_utilities/src/ast_matching/sqlpattern_matcher.rs) takesscrape_intervalas seconds. Both call sites currently work around this with a/1000.0conversion:asap-query-engine/src/engines/simple_engine/sql.rs:404— passesprometheus_scrape_interval_ms / 1000.0asap-planner-rs/src/planner/sql.rs:75— passesdata_ingestion_interval as f64(seconds, pre-rename)
When this issue renames
data_ingestion_interval→data_ingestion_interval_ms, the planner call site will need updating. At that point, consider whether to also renameSQLPatternMatcher'sscrape_intervalfield toscrape_interval_msand remove both/1000.0conversions, or keep the boundary conversion as-is. Flagging here so it doesn't get missed.- linked a pull request that will close this issuefix(planner): change more variables to ms precision #450
on Jun 26, 2026 - linked a pull request that will close this issuefix(planner, tools): use milliseconds for repetition_delay #449
on Jun 26, 2026
Background
#398 adds millisecond precision to the PromQL planner path (
prometheus_scrape_interval,step,range_duration,repetition_delay,window_size,slide_interval). The SQL and Elastic controllers have an analogous seconds-based field,data_ingestion_interval(asap-planner-rs/src/sql/generator.rs,src/elastic_dsl/generator.rs), with the same underlying problem — sub-second ingestion intervals can't be expressed.The original issue (#398) doesn't mention this field, so it was explicitly left out of scope there and flagged as a known follow-up rather than silently expanded into.
Work
Same fix shape as #398: rename
data_ingestion_intervaltodata_ingestion_interval_msacross the SQL/Elastic generator path, delete now-redundant* 1000conversions at consumption sites, update fixtures/tests.See
.design_docs/issue-398-millisecond-precision-plan.md("Scope boundary" and "Follow-up Issues" sections) for context.