Repository navigation
Conversation
zzylol
force-pushed
the
stack/cleanup-6-delete-candidate-selection
branch
from
October 5, 2026 03:07
bdb713a to
7cc8150
Compare
This was referenced Oct 5, 2026
…f the legacy search Stage 1 (pass1/logical_candidates.rs, pass2/*) and the accuracy estimators imported their realization catalogue and summary-input rules from the legacy search modules (pass1/replacement.rs, pass1/grouping.rs, pass2/reconciliation.rs). Move those items into a new pass1/realization.rs module, and hydra_guarantee into accuracy/estimators, so the stage pipeline no longer reaches the legacy search. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ization Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
stack/cleanup-7-stage1-helpers
branch
from
October 5, 2026 06:21
a35b447 to
c41b508
Compare
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: #574 → #620 → #618 → #621 → #627 → #625 → #628 → #632 → #634 → #616 → #617 → #622 → #624 → #629 → #630 → #631 → #633 → #635 → #636 → #637
Rebased: added
fix: integrate with #621: the executor's UnivMon test importsdefault_size_paramsfrompass1::realization.Problem
Q68 (a) deletes the legacy search (
ASAPStrategies,search_workload*, legacy grouping/composition/propagation). Stage 1 still reached into it:pass1/logical_candidates.rs,pass2/summary_capability.rs,pass2/window_composition.rsand the accuracy estimators imported their realization catalogue and summary-input rules frompass1/replacement.rs,pass1/grouping.rsandpass2/reconciliation.rs. Deleting those modules would break the stage pipeline.Changes
Pure move, no behaviour change:
pass1/realization.rs(Stage 1's realization catalogue and input rules), moved verbatim from the legacy modules:replacement.rs:Realization,DEFAULT_DELTA,summary_candidates,accuracy_target,accuracy_budget,default_size_params,PhysicalSummaryInput,PhysicalSummaryInputRuleResult,realize_keyed_additive_summary_input,schema_column_ref,summarised_column,column_ref,summarised_inputgrouping.rs:has_subpopulations(with its tests)reconciliation.rs:dominateshydra_guarantee(and its test) moves fromgrouping.rstoaccuracy/estimators/mod.rs, its only Stage 1 caller.summarised_inputreturnsResult<_, &'static str>instead of the legacyRealizationError; the legacy caller wraps it inRealizationError::PhysicalRealization, with the same message.Realization,summary_candidates,has_subpopulationsnow come frompass1::realization), and the external paths in plan-selection'scost_model.rs/empirical_cost.rsand three tests (planner/tests/summary_sharing.rs,frontend-sql/tests/frequency_l2.rs,integration-tests/tests/planner_layering_example2.rs). No re-export stays at the old paths.After this PR, the stage pipeline's modules (
pass1/logical_candidates.rs,pass1/realization.rs,pass2/identical_expressions.rs,pass2/summary_capability.rs,pass2/window_composition.rs,accuracy/estimators/*) import nothing frompass1::{replacement, grouping, exact_composition, rollup, rewrite, explanation, maintained_population}orpass2::{reconciliation, topk_reuse}(checked by grep).accuracy/mod.rsstill importsexact_composition::ExactOperationforAccuracyModel::exact_operation_rule. That trait method is dropped in step 8 (Q53).Stacked on #630.
Test plan
cargo fmt --all --checkcargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo test --workspace --locked: 1519 passed, 0 failed, 14 ignored (after the rebase on main d4869a7; was 1495 passed, 22 ignored)🤖 Generated with Claude Code