Repository navigation
Conversation
…s, MUI tooltips and Google account linking - Watching: people start watching a task or page only by taking part (now also by reacting or attaching files) and can stop watching themselves; nobody can add or remove anyone else, and the manual "start watching" route is gone. - A task link from a notification opens the board of the space the task lives in. - Comments: the text, actions and replies line up under the author's name, beside the avatar. - The space Tasks tab folds its epic and view options into the space menu instead of a second one. - Settings: Profile, Preferences and every space settings form show Save changes only when something changed, on the right, in space that is always reserved so nothing jumps. - Profile: a larger picture with change and remove controls on hover. - Sidebar: long titles under a space truncate with an ellipsis. - Saving rich text drops empty lines and line breaks after the last words. - Tooltips: icon buttons, add buttons and other hover hints use MUI tooltips. Files' New folder and Upload are icon buttons. - Email change: the confirmation and the warning share a subject and thread headers, so one mailbox shows them as one conversation; the warning reads as a normal change. - Google sign-in: an unknown Google account on a browser that has signed in to Strata before, or one whose address an account already uses, is offered to link to that account with its password (and two-step code) instead of creating a duplicate account or failing.
# Conflicts: # app/frontend/src/pages/DrivePage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Watching, comments, settings saving, tooltips, sidebar and Files polish, plus two account fixes: email-change emails and Google sign-in for an account that already exists.
Watching
PUT /items/:id/watch(start watching by hand);PUT /items/:id/watchers/:userIdandDELETE /items/:id/watchers/:userId(add or remove someone else).GET /items/:id/watchersandDELETE /items/:id/watchstay./tasks?task=<id>.TasksPagenow looks the task up, and if it lives in a space you belong to, redirects to that space's Tasks board with the same query.tasks.spec.ts"lets editors add and remove other watchers" asserted the removed behaviour. It is replaced by "starts watching only by taking part, and nobody can change who else is watching". The outsider check now usesDELETE /watch.Comments
TaskTicket) and page comments (NoteComments).withoutTrailingLinesinrich-document.ts, applied inRichTextEditor). The quick task description trims its trailing lines too.Tasks page
useSpaceMenuslot. The row no longer shows two "more" buttons. The personal Tasks page is unchanged.Settings
SavedForm(moved out ofSpaceSettings) is now used by Profile, Preferences and every space settings form:MonthStartFieldgainedonChange.Tooltips
Tip, a MUITooltipwrapper with consistent delays, and a StrataIconButtonthat wraps the shared UI one withTip. Every icon button in Strata now imports the local one.AddButtonand the file upload button;titleon purpose: draggable agenda blocks and sidebar row links. A MUI tooltip would follow the pointer while dragging or resizing.Sidebar
.revealnow usesgrid-template-columns: minmax(0, 1fr).Email change
In-Reply-To/Referencesheaders. When both addresses land in one mailbox, they show as a single conversation.account.spec.tsrequires.Google sign-in for someone who already has an account
When "Continue with Google" brings a Google account that isn't linked yet:
known_devicesmatch): this covers a Google account renamed to a new address. The user is asked "Is this your Strata account?" and can sign in to link it, or Create a new account with Google.How it works:
strata_googlecookie for 10 minutes.POST /auth/google/existing(reusingAuthService.loginandcompleteTwoStep) andPOST /auth/google/new.Tests
rich-document.spec.ts.google-auth.spec.ts: email match asks for the password; known browser; linking with a two-step code; creating from the prompt.account.spec.ts: threading.tasks.spec.ts(integration, described above).Not verified