Repository navigation
fix(deploy): render compose without process variables the env files supply - #44
Merged
Merged
Conversation
…les supply
The Deploy workflow sets PROJECT for its project input, empty on a push, and
Compose prefers the process environment over --env-file, so ${PROJECT} rendered
empty and no route could be found for any project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Deploy run for #43 failed every compose project with
no service joins the edge network as <slug>. The workflow setsPROJECT: ${{ inputs.project }}for the job, empty on a push, and Compose gives the process environment priority over--env-file, so${PROJECT}rendered empty. PR checks passed because that job has noPROJECT.deploy.pynow runsdocker composewithout any process variable that one of its env files supplies. Nothing reached the agent in the failed run: the four projects kept running as before.Checked locally with
PROJECT=wrongandHOST=wrongin the environment: all four routes render;deploy.py check,check-memory.pyandcheck-values.pypass.