Repository navigation
fix: copy app into the runtime image, and check that the image starts - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sha-1498718(#32) never became ready on the VPS, andproject-graphite.comwent down.Cause. The runtime image copies only
server/,build/andscripts/rules.mjs. Since #32,server/settings.tsimportsapp/settings.tsandserver/share.tsimportsapp/share.tsat runtime, not only for types. Neither file was in the image, so the server could not start.Fix. The image now copies
app/, about 100 KB of source.Guard. A new Image starts job builds the image, runs it in production mode against a Redis service with placeholder credentials, and waits for
/health/ready. Lint and unit tests can't see a file missing from the image; this job can.Checked locally. Built the image and ran it with
NODE_ENV=production:/health/ready200,/200,/share/home.png200 with the DejaVu fonts drawing the text.Order. Project-Graphite/platform#54 rolls the hub back to
sha-84803f5to restore the site. Merging this PR builds a fixed image, and CI records its tag over the rollback.