Repository navigation
Conversation
… tooltip The tooltip looked for a point exactly on the pointer's time rounded to the step. History points sit on step boundaries, but live frames carry the millisecond they were sampled, so none ever matched. It now takes the nearest point within half a step, and the newest second no longer falls off the edge.
Member
Author
|
Already on main through #27, which carries this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live range showed no tooltip.
Chartmatched points withpoint.at === at, whereatis the pointer's time rounded to the step. History points are aligned to their step; live frames are stamped with the millisecond they were sampled, so nothing matched.The tooltip, the nearest-line highlight and the project breakdown now take the nearest point within half a step, and the pointer may reach half a step past the newest point.
Checks:
tsc(web),oxlint,npm run build. Not tried in a browser.