Repository navigation
fix: direct billboard playback, YouTube modal TV clickability, and default to Firebase Crashlytics - #858
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
area: android
293a00a to
d88d050
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 293a00a1b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var autoPlayPending by rememberSaveable(mediaType, mediaId) { mutableStateOf(autoPlay) } | ||
|
|
||
| LaunchedEffect(autoPlayPending, uiState.isLoading, uiState.item, kidsGatePending) { | ||
| if (autoPlayPending && !uiState.isLoading && uiState.item != null && !kidsGatePending) { |
There was a problem hiding this comment.
When a TV item is played from a billboard or card without nextEpisode (for example, a catalog item for a show with watch history), this condition can fire as soon as metadata loads. DetailsViewModel.loadDetails publishes isLoading = false before its asynchronous resume and episode-progress work fills playSeason and playEpisode; the Play handler then falls back to episode index 0 or S1E1, starting the wrong episode instead of resuming or choosing the next unwatched episode. Wait for the playback target to resolve before firing.
Useful? React with 👍 / 👎.
|
Thanks Himanth! Merged with your original commits preserved. I fixed a race where Home autoplay could start before resume history/episode progress resolved, which could select the wrong episode or lose the resume position. Autoplay now waits for the resolved target, still respects autoplay-off, and starts only once. I also updated outdated settings/filter mocks in the affected test fixtures without removing assertions. Verified: Play compilation, Sideload APK/test build, all 2,917 JVM tests (3 existing skips), all 10 Details autoplay/remote-control tests on an Android TV emulator, crash-report tests, and web TypeScript. The Android CI job passed on the production-fix commit; the final test-fixture-only push triggered another run. The four web-suite failures also occur on main and are unrelated to this PR; I have not disabled those checks. Live YouTube/provider playback was not exercised. |
Summary of Changes
This PR includes three focused improvements:
Default Crash Reporting to Firebase Crashlytics:
EXTRA_CRASH_PROVIDERfromMainActivitytoCrashReportActivity, defaulting to Firebase Crashlytics.CrashReportActivityto default to Firebase Crashlytics unless explicitly specified as Sentry.netlify-arvio-tv-site/report/index.htmlandweb/app/report/page.tsx) to open the Firebase Crashlytics dashboard unlessprovider=sentryis passed.netlify-arvio-tv-site/scripts/crash-report.test.cjs.Direct Playback from Home Billboard & Autoplay Navigation:
YouTube Trailer Modal TV Clickability:
YouTubeTrailerModalis clickable and focusable via TV D-pad.