Skip to content

Remove unused params - #446

Merged
brucetony merged 4 commits into
developfrom
remove-unused-params
Oct 30, 2026
Merged

brucetony merged 4 commits into
developfrom
remove-unused-params

Conversation

@brucetony

@brucetony brucetony commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Global search in the analyses table now matches analysis and project names. In the projects table, it matches project IDs and names. Node names are no longer included in either table’s search, so results are limited to the analysis or project details shown in those tables. You may see different search results when your query previously matched a node name.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 357b561a-b4b6-4fa3-b853-bbc50ce554b2
Commits

Reviewing files that changed from the base of the PR and between 63b28a7 and 41f9e59.

Files selected for processing: 2
  • app/services/Api.ts
  • app/services/hub_adapter_swagger.json

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 207fa519-e145-40ca-b87c-8d3d285463a7
Commits

Reviewing files that changed from the base of the PR and between b96854b and 63b28a7.

Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 5
  • app/components/analysis/AnalysesTable.vue
  • app/components/projects/ProjectsTable.vue
  • app/composables/useAPIFetch.ts
  • app/composables/useAnalyses.ts
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Analysis and project table searches no longer include node.name. Related include queries no longer request node. The Nuxt and ESLint dependency ranges are updated.

Changes: Table Search and Include Queries

Layer / File(s) Summary
Narrow table search and include queries
app/components/analysis/AnalysesTable.vue, app/components/projects/ProjectsTable.vue, app/composables/useAPIFetch.ts, app/composables/useAnalyses.ts
Analysis searches use analysis and project names. Project searches use ID and project name. The related include queries request analysis or project without node.

Dependency Range Updates

Layer / File(s) Summary
Update Nuxt and ESLint ranges
package.json
The Nuxt dependency range changes to ^4.6.3. The ESLint development dependency range changes to ~10.13.0.

Priority: Pending latest changes

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Merge Risk: Minimal · previous review 63b28

The changes remove unused node data without breaking inspected consumers, and the dependency updates are lockfile-consistent.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title identifies the main change: removing unused request parameters and node-related search fields. It is concise and related to the changeset, although it does not mention the dependency updates…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title identifies the main change: removing unused request parameters and node-related search fields. It is concise and related to the changeset, although it does not mention the dependency updates.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files. (3 skipped: 3 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tada5hi

tada5hi Bot commented Oct 30, 2026

Copy link
Copy Markdown

Merge PrivateAIM/node-ui#‍446?

PR: Remove unused params, authored by brucetony. Automatic merge is not allowed because this is not a Dependabot or Renovate PR. Dependency bump classification is unknown and no dependency updates were identified by the assessment. Checks are successful, with none pending, failing, or missing. Approve merging this exact head?

Head: 63b28a73bab15df6a6a7d9dc2abfda425ffd94cb

Waiting for approval until 2026-10-31T11:48:12.630Z. Approve or deny: https://maintainer.placzek.dev/ui/approvals?run=be8394fb-246c-4d19-86f5-9b8add9f45fd&approval=1%3Acall_3a60cc604e734661b2981c6b51d94dcf%3A0
Run be8394fb-246c-4d19-86f5-9b8add9f45fd of agent maintainer.

@brucetony
brucetony merged commit cc18871 into develop Oct 30, 2026
3 checks passed
@brucetony
brucetony deleted the remove-unused-params branch October 30, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant