Repository navigation
fix(rate-limiter): enforce bet and oracle limits and use ledger units… - #1476
Merged
greatest0fallt1me merged 2 commits intoOct 24, 2026
Merged
greatest0fallt1me merged 2 commits into
greatest0fallt1me merged 2 commits into
Conversation
… for bucket TTL Wires the dead rate-limit paths so bet_limit, oracle_call_limit, and the per-ledger bet cap are actually enforced. Fixes a critical bug where TTL extended in seconds instead of ledger counts, causing rent inflation. Changes: - Enforce bet_limit in place_bet_inner, place_bets, and vote - Enforce oracle_call_limit in fetch_oracle_result before external calls - Expose set_per_ledger_bet_cap entrypoint with require_primary_admin - Fix TTL: convert seconds to ledgers using LEDGER_SECONDS constant - Fix voting limit: change key from (user, market) to (user) globally - Fix get_rate_limit_status to return accurate reset time in HalfLife mode Test coverage: 12 scenarios covering limits, batch atomicity, TTL, error precedence Closes Predictify-org#1464
|
@Kiosh-123 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> # Conflicts: # contracts/predictify-hybrid/IMPLEMENTATION_SUMMARY.md # contracts/predictify-hybrid/src/bets.rs
greatest0fallt1me
added a commit
that referenced
this pull request
Oct 24, 2026
… limit #1476 changed the voting bucket key from (user, market) to user, making the voting limit global per user. The old test still expected a fresh budget on a second market. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
greatest0fallt1me
added a commit
that referenced
this pull request
Oct 24, 2026
* fix(ci): restore green master build after #1471/#1476/#1478 - rate_limit_enforcement_tests (from #1476) never compiled: it imported a non-existent crate::test_utils, called CircuitBreaker::set_state and CircuitBreakerState::Open which do not exist, and lacked the testutils Ledger trait import. Its tests also registered a second, uninitialised contract after setup, so they could not pass. Drop the module; the rate-limiter enforcement changes from #1476 are kept. - BudgetGuard::check compared *consumed* instructions against the "minimum remaining" threshold, so distribute_payouts aborted with OperationWouldExceedBudget after 100k instructions. This was hidden while resolution auto-distributed with `let _ =`; #1471 made distribution an explicit call and its payout gating tests exposed it. Compute remaining headroom against a per-transaction ceiling instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(rate-limiter): align test_different_markets with per-user voting limit #1476 changed the voting bucket key from (user, market) to user, making the voting limit global per user. The old test still expected a fresh budget on a second market. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(conservation): distribute payouts explicitly after the dispute window #1471 removed the automatic distribution from resolve_market_manual, so the conservation test must wait out the post-resolution dispute window and call distribute_payouts before checking credited balances. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: greatest0fallt1me <greatest0fallt1me@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1464
… for bucket TTL
Wires the dead rate-limit paths so bet_limit, oracle_call_limit, and the per-ledger bet cap are actually enforced. Fixes a critical bug where TTL extended in seconds instead of ledger counts, causing rent inflation.
Changes:
Test coverage: 12 scenarios covering limits, batch atomicity, TTL, error precedence
Closes #1464
Pull Request Description
📋 Basic Information
Type of Change
Please select the type of change this PR introduces:
Related Issues
Closes #(issue number)
Fixes #(issue number)
Related to #(issue number)
Priority Level
📝 Detailed Description
What does this PR do?
Why is this change needed?
How was this tested?
Alternative Solutions Considered
🏗️ Smart Contract Specific
Contract Changes
Please check all that apply:
Oracle Integration
Market Resolution Logic
Security Considerations
🧪 Testing
Test Coverage
Test Results
Manual Testing Steps
📚 Documentation
Documentation Updates
Breaking Changes
Breaking Changes:
Migration Guide:
🔍 Code Quality
Code Review Checklist
Performance Impact
Security Review
🚀 Deployment & Integration
Deployment Notes
Integration Points
📊 Impact Assessment
User Impact
Business Impact
✅ Final Checklist
Pre-Submission
Review Readiness
📸 Screenshots (if applicable)
🔗 Additional Resources
💬 Notes for Reviewers
Please pay special attention to:
Questions for reviewers:
Thank you for your contribution to Predictify! 🚀