Skip to content

Verify make pgtle produces output for both extensions - #104

Merged
jnasbyupgrade merged 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:issue-71-multi-ext-pgtle
Oct 15, 2026
Merged

jnasbyupgrade merged 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:issue-71-multi-ext-pgtle

Conversation

@jnasbyupgrade

Copy link
Copy Markdown
Contributor

test/standard/multi-extension.bats is the only test that runs make pgtle with more than one extension, but it only checked that make exits 0.

That exit status can't prove both extensions were processed: the pgtle recipe in base.mk joins its per-extension pgtle.sh calls with ;, so only the last extension's status reaches make. A failure or a dropped extension for ext_alpha still exits 0.

This adds inline assertions to the existing "make generates versioned SQL files" test:

  • at least one pg_tle/<range>/ directory exists, and
  • every range directory contains both ext_alpha.sql and ext_beta.sql.

Verified locally that each assertion fails when its case is forced (one ext_alpha.sql removed; pg_tle/ removed), and that the full suite passes.

Fixes #71

🤖 Generated with Claude Code

The multi-extension test only checked that `make pgtle` exits 0. The
`pgtle` recipe joins its per-extension pgtle.sh calls with `;`, so only
the last extension's status reaches make: a failure (or a skipped
extension) for ext_alpha still exits 0.

Assert that at least one `pg_tle/<range>/` directory exists and that
every range contains both `ext_alpha.sql` and `ext_beta.sql`.

Fixes Postgres-Extensions#71

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f5a061c5-2d6d-44e2-ba5b-44c86540637c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jnasbyupgrade
jnasbyupgrade marked this pull request as ready for review October 14, 2026 19:02
@jnasbyupgrade
jnasbyupgrade merged commit ba6fb22 into Postgres-Extensions:master Oct 15, 2026
9 checks passed
@jnasbyupgrade
jnasbyupgrade deleted the issue-71-multi-ext-pgtle branch October 15, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multi-extension.bats doesn't verify make pgtle actually processes both extensions

1 participant