Repository navigation
Test pgtle.sh --pgtle-version range-name validation - #101
Merged
jnasbyupgrade merged 2 commits intoOct 7, 2026
Merged
jnasbyupgrade merged 2 commits into
jnasbyupgrade merged 2 commits into
Conversation
Add tests for pgxntool Postgres-Extensions/pgxntool#134 (fd92287) (reject values that aren't an exact pg_tle range name): - `pgtle.sh --pgtle-version` accepts only `1.0.0-1.4.0`, `1.4.0-1.5.0`, `1.5.0+` - A plain pg_tle version errors with a "did you mean <range>?" hint New `test/standard/pgtle-version-validate.bats` invokes `pgtle.sh` directly against a bare scratch extension (no foundation, no make, no PostgreSQL): - Each exact range name generates only `pg_tle/<range>/` - Plain versions, including both range boundaries and a pre-release, fail with the hint naming the range `--get-dir` puts them in - Unparseable values (`latest`, empty, an out-of-range component) fail with the valid-range list and no hint Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jnasbyupgrade
added a commit
to Postgres-Extensions/pgxntool
that referenced
this pull request
Oct 7, 2026
…e name (#134) `make pgtle PGXNTOOL_PGTLE_VERSION=<value>` and `pgtle.sh --pgtle-version <value>` now fail unless `<value>` is exactly one of the pg_tle range names in `pgtle.sh`'s `PGTLE_VERSIONS`: `1.0.0-1.4.0`, `1.4.0-1.5.0` or `1.5.0+`. Related pgxntool-test PR: Postgres-Extensions/pgxntool-test#101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related pgxntool PR: Postgres-Extensions/pgxntool#134
Tests for
pgtle.sh --pgtle-version, which now accepts only an exact pg_tle range name (1.0.0-1.4.0,1.4.0-1.5.0,1.5.0+) and rejects a plain pg_tle version with a "did you mean ?" hint.New
test/standard/pgtle-version-validate.batscallspgtle.shdirectly on a bare scratch extension, with no foundation environment, no make and no PostgreSQL:pg_tle/<range>/.--get-dirputs them in. Cases:1.0.0,1.3.9,1.4.0,1.5.0rc1,1.5.0,1.5.2, which cover both range boundaries and a pre-release.latest, empty,1.5.1000) fail with the list of valid ranges and no hint.No new make-level test:
make pgtleonly forwardsPGXNTOOL_PGTLE_VERSIONto--pgtle-version, and04-pgtle.batsalready covers that forwarding.Merge order
Merge Postgres-Extensions/pgxntool#134 first. This PR adds coverage for behavior that PR adds. If this PR merges first, the new tests fail against pgxntool master for every unrelated pgxntool-test PR (CLAUDE.md, "Merge Order for Paired PRs").
🤖 Generated with Claude Code